summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Wieser <wieser.eric@gmail.com>2018-06-07 23:51:03 -0700
committerEric Wieser <wieser.eric@gmail.com>2018-06-08 11:25:07 -0700
commit6172a8bb5b46a9894647b46beed2b771b5017e65 (patch)
tree32bcf72b725e523c7ff764631664536ebb824e30
parentda5eaf97281453083252c22b2b94aded846a936b (diff)
downloadnumpy-6172a8bb5b46a9894647b46beed2b771b5017e65.tar.gz
MAINT: Don't steal a reference
-rw-r--r--numpy/core/src/multiarray/ctors.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/numpy/core/src/multiarray/ctors.c b/numpy/core/src/multiarray/ctors.c
index cdef899a0..a2d6a9e2e 100644
--- a/numpy/core/src/multiarray/ctors.c
+++ b/numpy/core/src/multiarray/ctors.c
@@ -1302,7 +1302,6 @@ PyArray_New(PyTypeObject *subtype, int nd, npy_intp *dims, int type_num,
}
-/* Steals a reference to the memory view */
NPY_NO_EXPORT PyObject *
_array_from_buffer_3118(PyObject *memoryview)
{
@@ -1379,13 +1378,11 @@ _array_from_buffer_3118(PyObject *memoryview)
&PyArray_Type, descr,
nd, shape, strides, view->buf,
flags, NULL, memoryview);
- Py_DECREF(memoryview);
return r;
fail:
Py_XDECREF(r);
Py_XDECREF(descr);
- Py_DECREF(memoryview);
return NULL;
}
@@ -1506,6 +1503,7 @@ PyArray_GetArrayParamsFromObject(PyObject *op,
}
else {
PyObject *arr = _array_from_buffer_3118(memoryview);
+ Py_DECREF(memoryview);
if (arr == NULL) {
return -1;
}