diff options
| author | Ben Nathanson <github@bigriver.xyz> | 2020-10-03 17:03:18 -0400 |
|---|---|---|
| committer | Ben Nathanson <github@bigriver.xyz> | 2020-10-03 17:03:18 -0400 |
| commit | 93b5da05bcaa39d76b07c334690f85d5d54f54df (patch) | |
| tree | 3ad204170ab135de6d5d6b8edfc3ee045276b6a6 /.github | |
| parent | 88eda2f2f430e2f3b7e580fe38ac31e4c5fac942 (diff) | |
| download | numpy-93b5da05bcaa39d76b07c334690f85d5d54f54df.tar.gz | |
DOC: Cleaner PR template
Make the instructions easy to see and hard to delete unread.
Moves some text to new sections in dev/development_workflow.rst.
The dashes above and below the heading, which
in monospace seem too long, fit it
well in Chromium browsers and reasonably in Firefox.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 40 |
1 files changed, 22 insertions, 18 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3634292f8..075d2519b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,18 +1,22 @@ -<!-- Please be sure you are following the instructions in the dev guidelines -http://www.numpy.org/devdocs/dev/development_workflow.html ---> - -<!-- We'd appreciate it if your commit message is properly formatted -http://www.numpy.org/devdocs/dev/development_workflow.html#writing-the-commit-message ---> - -<!-- If you're submitting a new feature or substantial change in functionality, -make sure you discuss your changes in the numpy-discussion mailing list first: -https://mail.python.org/mailman/listinfo/numpy-discussion --> - -<!-- We try to review your pull request as soon as we can, typically within a week. -If you do not get any review comments within two weeks, please feel free to ask for -feedback by adding a new comment on your PR (this will notify maintainers). If your -PR is large or complicated, asking for input on the numpy-discussion mailing -list may also be useful. ---> +<!--
+
+ ----------------------------------------------------------------
+ MAKE SURE YOUR PR GETS THE ATTENTION IT DESERVES!
+ ----------------------------------------------------------------
+
+
+* FORMAT IT RIGHT:
+ http://www.numpy.org/devdocs/dev/development_workflow.html#writing-the-commit-message
+
+
+* IF IT'S A NEW FEATURE OR API CHANGE, TEST THE WATERS
+ http://www.numpy.org/devdocs/dev/development_workflow.html#get-the-mailing-list-s-opinion
+
+
+* HIT ALL THE GUIDELINES:
+ https://numpy.org/devdocs/dev/index.html#guidelines
+
+
+* WHAT TO DO IF WE HAVEN'T GOTTEN BACK TO YOU:
+ http://www.numpy.org/devdocs/dev/development_workflow.html#getting-your-pr-reviewed
+-->
|