diff options
| author | UENISHI Kota <kuenishi+github@gmail.com> | 2010-07-01 01:14:38 +0900 |
|---|---|---|
| committer | UENISHI Kota <kuenishi+github@gmail.com> | 2010-07-01 01:14:38 +0900 |
| commit | ff5d5d7cbcb7e136370f3450d67b06244d5c3bc7 (patch) | |
| tree | 4fabfcd8392a4fc5a348f53df2870fd337f95634 | |
| parent | 370e92b1a6d79cd6d65840cae588ded11b167fce (diff) | |
| download | msgpack-python-ff5d5d7cbcb7e136370f3450d67b06244d5c3bc7.tar.gz | |
erlang: updated the comments
| -rw-r--r-- | erlang/msgpack.erl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/erlang/msgpack.erl b/erlang/msgpack.erl index 6d94a23..8a54271 100644 --- a/erlang/msgpack.erl +++ b/erlang/msgpack.erl @@ -162,7 +162,7 @@ pack_array_([], Acc) -> Acc; pack_array_([Head|Tail], Acc) -> pack_array_(Tail, <<Acc/binary, (pack(Head))/binary>>). -% FIXME! this should be tail-recursive and without lists:reverse/1 +% FIXME! this should be without lists:reverse/1 unpack_array_(<<>>, 0, RetList) -> {lists:reverse(RetList), <<>>}; unpack_array_(Remain, 0, RetList) when is_binary(Remain)-> {lists:reverse(RetList), Remain}; unpack_array_(<<>>, RestLen, _RetList) when RestLen > 0 -> {more, undefined}; @@ -176,7 +176,7 @@ pack_map_([], Acc) -> Acc; pack_map_([{Key,Value}|Tail], Acc) -> pack_map_(Tail, << Acc/binary, (pack(Key))/binary, (pack(Value))/binary>>). -% FIXME: write test for unpack_map/1 +% FIXME! this should be without lists:reverse/1 -spec unpack_map_(binary(), non_neg_integer(), [{term(), msgpack_term()}])-> {more, non_neg_integer()} | { any(), binary()}. unpack_map_(Bin, 0, Acc) -> {{lists:reverse(Acc)}, Bin}; |
