summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien Jehannet <julien.jehannet@logilab.fr>2010-11-29 16:59:43 +0100
committerJulien Jehannet <julien.jehannet@logilab.fr>2010-11-29 16:59:43 +0100
commita87b90ef093e54f0c062f9fcd098fbf21662ac2a (patch)
tree812c18152a35b125431d3d005a7abfe4f0ceb980
parent9fbbea7016de76357ebb5752e0cf6402d739b0e4 (diff)
downloadlogilab-common-a87b90ef093e54f0c062f9fcd098fbf21662ac2a.tar.gz
[testlib] do not stop generative test if exception occured
-rw-r--r--test/unittest_testlib.py4
-rw-r--r--testlib.py5
2 files changed, 5 insertions, 4 deletions
diff --git a/test/unittest_testlib.py b/test/unittest_testlib.py
index f68404b..012065e 100644
--- a/test/unittest_testlib.py
+++ b/test/unittest_testlib.py
@@ -338,7 +338,7 @@ class GenerativeTestsTC(TestCase):
yield self.assertEqual, i, i
def ouch(self): raise ValueError('stop !')
result = self.runner.run(FooTC('test_generative'))
- self.assertEqual(result.testsRun, 6)
+ self.assertEqual(result.testsRun, 11)
self.assertEqual(len(result.failures), 0)
self.assertEqual(len(result.errors), 1)
@@ -404,7 +404,7 @@ class GenerativeTestsTC(TestCase):
yield InnerTest("check_%s"%i, self.check, i)
result = self.runner.run(FooTC('test_generative'))
- self.assertEqual(result.testsRun, 6)
+ self.assertEqual(result.testsRun, 10)
self.assertEqual(len(result.failures), 0)
self.assertEqual(len(result.errors), 1)
self.assertEqual(len(result.skipped), 0)
diff --git a/testlib.py b/testlib.py
index 18e332b..4cd2b0c 100644
--- a/testlib.py
+++ b/testlib.py
@@ -557,8 +557,9 @@ succeeded test into", osp.join(os.getcwd(), FILE_RESTART)
success = True
else:
success = False
- if status == 2:
- result.shouldStop = True
+ # XXX Don't stop anymore if an error occured
+ #if status == 2:
+ # result.shouldStop = True
if result.shouldStop: # either on error or on exitfirst + error
break
except: