summaryrefslogtreecommitdiff
path: root/kazoo/recipe/counter.py
diff options
context:
space:
mode:
authorLukasz Kawczynski <n@neuroid.pl>2016-06-10 14:31:35 +0100
committerLukasz Kawczynski <n@neuroid.pl>2016-06-10 14:40:21 +0100
commitb7aff3fb63625b992fc36df937ff545ec89155fe (patch)
tree56f94af481fa566fec801477c6bbe4e3b396a001 /kazoo/recipe/counter.py
parent1b4bca7cae660c8f9edd5c9693f9159e69bef320 (diff)
downloadkazoo-b7aff3fb63625b992fc36df937ff545ec89155fe.tar.gz
Counter: expose the previous and changed values.
This commit extends the `Counter` API with the `pre_value` and `post_value` attributes. These attributes are set when a counter is changed. Previously, if the counter was modified concurrently, it was not possible to access the exact value to which the counter was set after a successful increment or decrement.
Diffstat (limited to 'kazoo/recipe/counter.py')
-rw-r--r--kazoo/recipe/counter.py13
1 files changed, 11 insertions, 2 deletions
diff --git a/kazoo/recipe/counter.py b/kazoo/recipe/counter.py
index 2299742..a2768a3 100644
--- a/kazoo/recipe/counter.py
+++ b/kazoo/recipe/counter.py
@@ -34,10 +34,14 @@ class Counter(object):
counter += 2
counter -= 1
counter.value == 1
+ counter.pre_value == 2
+ counter.post_value == 1
counter = zk.Counter("/float", default=1.0)
counter += 2.0
counter.value == 3.0
+ counter.pre_value == 1.0
+ counter.post_value == 3.0
"""
def __init__(self, client, path, default=0):
@@ -53,6 +57,8 @@ class Counter(object):
self.default = default
self.default_type = type(default)
self._ensured_path = False
+ self.pre_value = None
+ self.post_value = None
def _ensure_node(self):
if not self._ensured_path:
@@ -79,12 +85,15 @@ class Counter(object):
return self
def _inner_change(self, value):
- data, version = self._value()
- data = repr(data + value).encode('ascii')
+ self.pre_value, version = self._value()
+ post_value = self.pre_value + value
+ data = repr(post_value).encode('ascii')
try:
self.client.set(self.path, data, version=version)
except BadVersionError: # pragma: nocover
+ self.post_value = None
raise ForceRetryError()
+ self.post_value = post_value
def __add__(self, value):
"""Add value to counter."""