diff options
| author | Ben Bangert <ben@groovie.org> | 2014-03-03 19:53:06 -0800 |
|---|---|---|
| committer | Ben Bangert <ben@groovie.org> | 2014-03-03 19:53:06 -0800 |
| commit | 8bddeaed38e2a225dac9bf88204b1ca3fcaaa3f3 (patch) | |
| tree | 6c155a4ace15e8e9bd630fddd3592816d9e34dfe | |
| parent | c42869458a924369c4a907826e84fe91f8156825 (diff) | |
| parent | 08f28e3dfd6d30cba016d60ee80cca0ae4ed1c3c (diff) | |
| download | kazoo-8bddeaed38e2a225dac9bf88204b1ca3fcaaa3f3.tar.gz | |
Merge pull request #164 from rgs1/make-acl-param-consistent-between-create-and-ensure-path
Empty list acl param should be consistent between public methods
| -rw-r--r-- | kazoo/client.py | 1 | ||||
| -rw-r--r-- | kazoo/tests/test_client.py | 7 |
2 files changed, 8 insertions, 0 deletions
diff --git a/kazoo/client.py b/kazoo/client.py index 145f099..3c4a3ea 100644 --- a/kazoo/client.py +++ b/kazoo/client.py @@ -771,6 +771,7 @@ class KazooClient(object): returns a non-zero error code. """ + acl = acl or self.default_acl return self.create_async(path, value, acl=acl, ephemeral=ephemeral, sequence=sequence, makepath=makepath).get() diff --git a/kazoo/tests/test_client.py b/kazoo/tests/test_client.py index 8f67f41..8629ce4 100644 --- a/kazoo/tests/test_client.py +++ b/kazoo/tests/test_client.py @@ -461,6 +461,13 @@ class TestClient(KazooTestCase): version = client.server_version() self.assertEqual(len(acls), 1 if version > (3, 4) else 2) + def test_create_acl_empty_list(self): + from kazoo.security import OPEN_ACL_UNSAFE + client = self.client + client.create("/1", acl=[]) + acls, stat = client.get_acls("/1") + self.assertEqual(acls, OPEN_ACL_UNSAFE) + def test_version_no_connection(self): @raises(ConnectionLoss) def testit(): |