summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2017-02-03 10:10:58 -0800
committerDana Powers <dana.powers@gmail.com>2017-02-03 10:10:58 -0800
commitd215bd98236783dc5bcdf1f59d94fef1e254bab1 (patch)
treea9e3a478a37b86949711fbfe322ec3eac92a41d7
parentff2a129bc6eb8520ea66f48bb77e6f39bb722684 (diff)
downloadkafka-python-d215bd98236783dc5bcdf1f59d94fef1e254bab1.tar.gz
DRY-up the OffsetCommitResponse Structs (#970)
-rw-r--r--kafka/protocol/commit.py22
1 files changed, 5 insertions, 17 deletions
diff --git a/kafka/protocol/commit.py b/kafka/protocol/commit.py
index 7891267..effba1e 100644
--- a/kafka/protocol/commit.py
+++ b/kafka/protocol/commit.py
@@ -19,30 +19,18 @@ class OffsetCommitResponse_v0(Struct):
class OffsetCommitResponse_v1(Struct):
API_KEY = 8
API_VERSION = 1
- SCHEMA = Schema(
- ('topics', Array(
- ('topic', String('utf-8')),
- ('partitions', Array(
- ('partition', Int32),
- ('error_code', Int16)))))
- )
+ SCHEMA = OffsetCommitResponse_v0.SCHEMA
class OffsetCommitResponse_v2(Struct):
API_KEY = 8
API_VERSION = 2
- SCHEMA = Schema(
- ('topics', Array(
- ('topic', String('utf-8')),
- ('partitions', Array(
- ('partition', Int32),
- ('error_code', Int16)))))
- )
+ SCHEMA = OffsetCommitResponse_v1.SCHEMA
class OffsetCommitRequest_v0(Struct):
API_KEY = 8
- API_VERSION = 0 # Zookeeper-backed storage
+ API_VERSION = 0 # Zookeeper-backed storage
RESPONSE_TYPE = OffsetCommitResponse_v0
SCHEMA = Schema(
('consumer_group', String('utf-8')),
@@ -57,7 +45,7 @@ class OffsetCommitRequest_v0(Struct):
class OffsetCommitRequest_v1(Struct):
API_KEY = 8
- API_VERSION = 1 # Kafka-backed storage
+ API_VERSION = 1 # Kafka-backed storage
RESPONSE_TYPE = OffsetCommitResponse_v1
SCHEMA = Schema(
('consumer_group', String('utf-8')),
@@ -75,7 +63,7 @@ class OffsetCommitRequest_v1(Struct):
class OffsetCommitRequest_v2(Struct):
API_KEY = 8
- API_VERSION = 2 # added retention_time, dropped timestamp
+ API_VERSION = 2 # added retention_time, dropped timestamp
RESPONSE_TYPE = OffsetCommitResponse_v2
SCHEMA = Schema(
('consumer_group', String('utf-8')),