summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2018-10-28 23:44:16 -0700
committerJeff Widman <jeff@jeffwidman.com>2018-10-29 02:02:07 -0700
commit3e332e83258f7cfffd4df13ba9f17647dc302c43 (patch)
tree0ba22658d8e0dd321e718f69d87d3af6e95e2458
parentca004366b863f23ecadd7a5bb3525dda4311f367 (diff)
downloadkafka-python-3e332e83258f7cfffd4df13ba9f17647dc302c43.tar.gz
Remove unused fixtures
These fixtures and helper functions were either unused or easily replaced.
-rw-r--r--test/test_consumer_group.py20
1 files changed, 2 insertions, 18 deletions
diff --git a/test/test_consumer_group.py b/test/test_consumer_group.py
index 01eb39e..5b468dc 100644
--- a/test/test_consumer_group.py
+++ b/test/test_consumer_group.py
@@ -6,7 +6,6 @@ import time
import pytest
from kafka.vendor import six
-from kafka import SimpleClient
from kafka.conn import ConnectionStates
from kafka.consumer.group import KafkaConsumer
from kafka.coordinator.base import MemberState, Generation
@@ -20,25 +19,10 @@ def get_connect_str(kafka_broker):
return kafka_broker.host + ':' + str(kafka_broker.port)
-@pytest.fixture
-def simple_client(kafka_broker):
- return SimpleClient(get_connect_str(kafka_broker))
-
-
-@pytest.fixture
-def topic(simple_client):
- topic = random_string(5)
- simple_client.ensure_topic_exists(topic)
- return topic
-
-
@pytest.mark.skipif(not version(), reason="No KAFKA_VERSION set")
-def test_consumer(kafka_broker, version):
-
+def test_consumer(kafka_broker, topic, version):
+ # The `topic` fixture is included because
# 0.8.2 brokers need a topic to function well
- if version >= (0, 8, 2) and version < (0, 9):
- topic(simple_client(kafka_broker))
-
consumer = KafkaConsumer(bootstrap_servers=get_connect_str(kafka_broker))
consumer.poll(500)
assert len(consumer._client._conns) > 0