diff options
author | Dana Powers <dana.powers@gmail.com> | 2018-01-11 17:38:47 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-01-11 17:38:47 -0800 |
commit | a8bf19f88e89bef571b7c1f952010bf405054987 (patch) | |
tree | 3c6929c0ab4b8e613a919020baa8d9810de7e0d0 | |
parent | da65a562bdd9ce20290d4375acc36b4977ef7026 (diff) | |
download | kafka-python-a8bf19f88e89bef571b7c1f952010bf405054987.tar.gz |
Honor reconnect_backoff in conn.connect() (#1342)
* Honor reconnect_backoff in conn.connect()
-rw-r--r-- | kafka/conn.py | 2 | ||||
-rw-r--r-- | test/test_conn.py | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/kafka/conn.py b/kafka/conn.py index 1243bdb..f30d987 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -278,7 +278,7 @@ class BrokerConnection(object): def connect(self): """Attempt to connect and return ConnectionState""" - if self.state is ConnectionStates.DISCONNECTED: + if self.state is ConnectionStates.DISCONNECTED and not self.blacked_out(): self.last_attempt = time.time() next_lookup = self._next_afi_host_port() if not next_lookup: diff --git a/test/test_conn.py b/test/test_conn.py index ef7925a..5698519 100644 --- a/test/test_conn.py +++ b/test/test_conn.py @@ -263,6 +263,7 @@ def test_lookup_on_connect(): ] with mock.patch("socket.getaddrinfo", return_value=mock_return2) as m: + conn.last_attempt = 0 conn.connect() m.assert_called_once_with(hostname, port, 0, 1) conn.close() @@ -288,6 +289,7 @@ def test_relookup_on_failure(): ] with mock.patch("socket.getaddrinfo", return_value=mock_return2) as m: + conn.last_attempt = 0 conn.connect() m.assert_called_once_with(hostname, port, 0, 1) conn.close() |