summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDana Powers <dana.powers@gmail.com>2016-04-24 15:37:59 -0700
committerDana Powers <dana.powers@gmail.com>2016-04-24 15:37:59 -0700
commita12be0af80a1c0903eb92566e75a63bcec988806 (patch)
tree9f29a943e5af347c4122eddeb874257db91d70db
parent56ba6075ac4d887fca54107cba9dcdc541b44c6c (diff)
downloadkafka-python-a12be0af80a1c0903eb92566e75a63bcec988806.tar.gz
Wait for future.is_done in check_version (fix for windows)
-rw-r--r--kafka/conn.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/kafka/conn.py b/kafka/conn.py
index f13ab64..084450b 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -506,19 +506,19 @@ class BrokerConnection(object):
# the attempt to write to a disconnected socket should
# immediately fail and allow us to infer that the prior
# request was unrecognized
- metadata = self.send(MetadataRequest[0]([]))
+ self.send(MetadataRequest[0]([]))
if self._sock:
self._sock.setblocking(True)
- resp_1 = self.recv()
- resp_2 = self.recv()
+ while not f.is_done:
+ self.recv()
if self._sock:
self._sock.setblocking(False)
- assert f.is_done, 'Future is not done? Please file bug report'
-
if f.succeeded():
log.info('Broker version identifed as %s', version)
+ log.info("Set configuration api_version='%s' to skip auto"
+ " check_version requests on startup", version)
break
# Only enable strict checking to verify that we understand failure