diff options
| author | Dana Powers <dana.powers@gmail.com> | 2018-03-09 17:18:04 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-03-09 17:18:04 -0500 |
| commit | 3dc536aa72c30f362a8edac33fe2f49a36876ae7 (patch) | |
| tree | 009c46c7e096ebee86dbf96677c40a60f3f207e2 | |
| parent | eb941ee47d04c27b5ae0b2a80bf43f07e5792592 (diff) | |
| download | kafka-python-3dc536aa72c30f362a8edac33fe2f49a36876ae7.tar.gz | |
Re-enable logging during broker version check (#1430)
| -rw-r--r-- | kafka/conn.py | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/kafka/conn.py b/kafka/conn.py index dae468b..1c0f320 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -906,6 +906,7 @@ class BrokerConnection(object): Returns: version tuple, i.e. (0, 10), (0, 9), (0, 8, 2), ... """ + log.info('Probing node %s broker version', self.node_id) # Monkeypatch some connection configurations to avoid timeouts override_config = { 'request_timeout_ms': timeout * 1000, @@ -924,17 +925,6 @@ class BrokerConnection(object): from kafka.protocol.admin import ApiVersionRequest, ListGroupsRequest from kafka.protocol.commit import OffsetFetchRequest, GroupCoordinatorRequest - # Socket errors are logged as exceptions and can alarm users. Mute them - from logging import Filter - - class ConnFilter(Filter): - def filter(self, record): - if record.funcName == 'check_version': - return True - return False - log_filter = ConnFilter() - log.addFilter(log_filter) - test_cases = [ # All cases starting from 0.10 will be based on ApiVersionResponse ((0, 10), ApiVersionRequest[0]()), @@ -1004,7 +994,6 @@ class BrokerConnection(object): else: raise Errors.UnrecognizedBrokerVersion() - log.removeFilter(log_filter) for key in stashed: self.config[key] = stashed[key] return version |