diff options
author | Jeff Widman <jeff@jeffwidman.com> | 2019-05-17 12:36:56 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-05-17 12:36:56 -0700 |
commit | f854791b1888dad633c78dfeadd0ea7ebcca1e8f (patch) | |
tree | 879e4d070cb9a1568b6aa712e59ede0ea1b33692 | |
parent | f6a8a38937688ea2cc5dc13d3d1039493be5c9b5 (diff) | |
download | kafka-python-f854791b1888dad633c78dfeadd0ea7ebcca1e8f.tar.gz |
A little python cleanup (#1805)
1. Remove unused variable: `partitions_for_topic`
2. No need to cast to list as `sorted()` already returns a list
3. Using `enumerate()` is cleaner than `range(len())` and handles assigning
`member`
-rw-r--r-- | kafka/coordinator/assignors/range.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/kafka/coordinator/assignors/range.py b/kafka/coordinator/assignors/range.py index c232d9e..299e39c 100644 --- a/kafka/coordinator/assignors/range.py +++ b/kafka/coordinator/assignors/range.py @@ -46,20 +46,18 @@ class RangePartitionAssignor(AbstractPartitionAssignor): if partitions is None: log.warning('No partition metadata for topic %s', topic) continue - partitions = sorted(list(partitions)) - partitions_for_topic = len(partitions) + partitions = sorted(partitions) consumers_for_topic.sort() partitions_per_consumer = len(partitions) // len(consumers_for_topic) consumers_with_extra = len(partitions) % len(consumers_for_topic) - for i in range(len(consumers_for_topic)): + for i, member in enumerate(consumers_for_topic): start = partitions_per_consumer * i start += min(i, consumers_with_extra) length = partitions_per_consumer if not i + 1 > consumers_with_extra: length += 1 - member = consumers_for_topic[i] assignment[member][topic] = partitions[start:start+length] protocol_assignment = {} |