summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2018-03-07 15:35:55 -0800
committerDana Powers <dana.powers@rd.io>2018-03-09 13:21:15 -0500
commit323f90e0a067c3fc0ce4b850724f265548240f70 (patch)
tree253a71f5f2354175db12262c720b14d8323076d3
parentfeea0df29d393c005439890ea1c606612637abe2 (diff)
downloadkafka-python-323f90e0a067c3fc0ce4b850724f265548240f70.tar.gz
Fixup client_async tests for connect_blocking
-rw-r--r--test/conftest.py1
-rw-r--r--test/test_client_async.py7
2 files changed, 5 insertions, 3 deletions
diff --git a/test/conftest.py b/test/conftest.py
index d53ff23..52ebfb4 100644
--- a/test/conftest.py
+++ b/test/conftest.py
@@ -128,6 +128,7 @@ def conn(mocker):
return state
conn._set_conn_state = _set_conn_state
conn.connect.side_effect = lambda: conn.state
+ conn.connect_blocking.return_value = True
conn.connecting = lambda: conn.state in (ConnectionStates.CONNECTING,
ConnectionStates.HANDSHAKE)
conn.connected = lambda: conn.state is ConnectionStates.CONNECTED
diff --git a/test/test_client_async.py b/test/test_client_async.py
index eece139..5343472 100644
--- a/test/test_client_async.py
+++ b/test/test_client_async.py
@@ -55,21 +55,22 @@ def test_bootstrap_success(conn):
kwargs.pop('state_change_callback')
kwargs.pop('node_id')
assert kwargs == cli.config
- conn.connect.assert_called_with()
+ conn.connect_blocking.assert_called_with()
conn.send.assert_called_once_with(MetadataRequest[0]([]))
assert cli._bootstrap_fails == 0
assert cli.cluster.brokers() == set([BrokerMetadata(0, 'foo', 12, None),
BrokerMetadata(1, 'bar', 34, None)])
+
def test_bootstrap_failure(conn):
- conn.state = ConnectionStates.DISCONNECTED
+ conn.connect_blocking.return_value = False
cli = KafkaClient(api_version=(0, 9))
args, kwargs = conn.call_args
assert args == ('localhost', 9092, socket.AF_UNSPEC)
kwargs.pop('state_change_callback')
kwargs.pop('node_id')
assert kwargs == cli.config
- conn.connect.assert_called_with()
+ conn.connect_blocking.assert_called_with()
conn.close.assert_called_with()
assert cli._bootstrap_fails == 1
assert cli.cluster.brokers() == set()