diff options
| author | Jeremy Paige <ucodery@gmail.com> | 2020-05-08 11:12:14 -0700 |
|---|---|---|
| committer | Jeremy Paige <ucodery@gmail.com> | 2020-05-08 11:12:14 -0700 |
| commit | 4f0e9508e40ec1f9da27dcfa622e19745a6a0e07 (patch) | |
| tree | b507fcaa31a2e1176af7308251c22eee3154798b /docs/contributing | |
| parent | cf93f354610e26c47124e00ac1c4fd5b4e376ad2 (diff) | |
| download | isort-4f0e9508e40ec1f9da27dcfa622e19745a6a0e07.tar.gz | |
speed up docker build times
Diffstat (limited to 'docs/contributing')
| -rw-r--r-- | docs/contributing/1.-contributing-guide.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/docs/contributing/1.-contributing-guide.md b/docs/contributing/1.-contributing-guide.md index 75727c38..04b3bb9b 100644 --- a/docs/contributing/1.-contributing-guide.md +++ b/docs/contributing/1.-contributing-guide.md @@ -46,7 +46,10 @@ A local test cycle might look like the following: 1. `docker build ./ -t isort:latest` 2. `docker run isort` -3. if #2 fails, debug, save, and goto #1; `docker run -it isort bash` will get you into the failed environment +3. if #2 fails, debug, save, and goto #1 + * `docker run -it isort bash` will get you into the failed environment + * `docker run -v $(git rev-parse --show-toplevel):/isort` will make changes made in the docker environment persist on your local checkout. + **TIP**: combine both to get an interacive docker shell that loads changes made locally, even after build, to quickly rerun that pesky failing test 4. `./scripts/docker.sh` 5. if #4 fails, debug, save and goto #1; you may need to specify a different `--build-arg VERSION=$VER` 6. congrats! you are probably ready to push a contribution |