Add test case for issue #909 - settings path skip files ignored

1 files changed, 28 insertions, 0 deletions

diff --git a/test_isort.py b/test_isort.py
index 8c157c4e..c76f3720 100644
--- a/test_isort.py
+++ b/test_isort.py
@@ -30,6 +30,7 @@ import os.path
 import posixpath
 import sys
 import sysconfig
+from subprocess import check_output
 
 import pytest
 
@@ -2888,3 +2889,30 @@ def test_to_ensure_correctly_handling_of_whitespace_only_issue_811(capsys):
     out, err = capsys.readouterr()
     assert out == ''
     assert err == ''
+
+
+def test_settings_path_skip_issue_909(tmpdir):
+    base_dir = tmpdir.mkdir('project')
+    config_dir = base_dir.mkdir('conf')
+    config_dir.join('.isort.cfg').write('[isort]\n'
+                                        'skip =\n'
+                                        '    file_to_be_skipped.py\n'
+                                        'skip_glob =\n'
+                                        '    *glob_skip*\n')
+
+    base_dir.join('file_glob_skip.py').write('import os\n'
+                                             '\n'
+                                             'print("Hello World")\n'
+                                             '\n'
+                                             'import sys\n')
+    base_dir.join('file_to_be_skipped.py').write('import os\n'
+                                                 '\n'
+                                                 'print("Hello World")'
+                                                 '\n'
+                                                 'import sys\n')
+
+    test_run_directory = os.getcwd()
+    os.chdir(str(base_dir))
+    results = check_output(['isort', '--check-only', '--settings-path=conf/.isort.cfg'])
+    os.chdir(str(test_run_directory))
+    assert b'skipped' in results