summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTimothy Crosley <timothy.crosley@gmail.com>2019-03-07 08:42:41 -0800
committerTimothy Crosley <timothy.crosley@gmail.com>2019-03-07 08:42:41 -0800
commit3a856aa26fc5563e68f87c5739b5aae4e02c65d3 (patch)
tree1cbef099eaf27c8646939fad9306df4017755754
parentd6f200ba77c18dfe9eb65c6de1175acf360a27b0 (diff)
downloadisort-3a856aa26fc5563e68f87c5739b5aae4e02c65d3.tar.gz
Add first additional test casefeature/fix-issue-885
-rw-r--r--test_isort.py9
1 files changed, 8 insertions, 1 deletions
diff --git a/test_isort.py b/test_isort.py
index a93ea366..86d5ae24 100644
--- a/test_isort.py
+++ b/test_isort.py
@@ -2756,13 +2756,16 @@ def test_quiet(tmpdir, capfd, quiet):
@pytest.mark.parametrize('enabled', (False, True))
def test_safety_excludes(tmpdir, enabled):
tmpdir.join("victim.py").write("# ...")
- tmpdir.mkdir(".tox").join("verysafe.py").write("# ...")
+ toxdir = tmpdir.mkdir(".tox")
+ toxdir.join("verysafe.py").write("# ...")
tmpdir.mkdir("lib").mkdir("python3.7").join("importantsystemlibrary.py").write("# ...")
tmpdir.mkdir(".pants.d").join("pants.py").write("import os")
config = dict(settings.default.copy(), safety_excludes=enabled)
skipped = []
codes = [str(tmpdir)],
main.iter_source_code(codes, config, skipped)
+
+ # if enabled files within nested unsafe directories should be skipped
file_names = set(os.path.relpath(f, str(tmpdir)) for f in main.iter_source_code([str(tmpdir)], config, skipped))
if enabled:
assert file_names == {'victim.py'}
@@ -2774,6 +2777,10 @@ def test_safety_excludes(tmpdir, enabled):
'victim.py'}
assert not skipped
+ # directly pointing to files within unsafe directories shouldn't skip them either way
+ file_names = set(os.path.relpath(f, str(toxdir)) for f in main.iter_source_code([str(toxdir)], config, skipped))
+ assert file_names == {'verysafe.py'}
+
def test_comments_not_removed_issue_576():
test_input = ('import distutils\n'