diff options
| author | Timothy Edmund Crosley <timothy.crosley@gmail.com> | 2019-03-10 22:13:49 -0700 |
|---|---|---|
| committer | Timothy Crosley <timothy.crosley@gmail.com> | 2019-03-10 22:57:34 -0700 |
| commit | e3fb26bd80b7e2c3f94ca95e867ad1dfe0d92370 (patch) | |
| tree | 1780c1cf593b1853cc815999b1ac6ce9e6ae201f | |
| parent | 283c5501de70a2082a533a73c07c45cf84bd9e17 (diff) | |
| download | isort-e3fb26bd80b7e2c3f94ca95e867ad1dfe0d92370.tar.gz | |
Merge pull request #898 from timothycrosley/feature/fix-issue-811
Fix handling of whitespace character
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | isort/isort.py | 4 | ||||
| -rw-r--r-- | test_isort.py | 13 |
3 files changed, 17 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index a5284c48..104d450b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ Planned: ### 4.3.15 - March 10, 2019 - hot fix release - Fixed a regression with handling streaming input from pipes (Issue #895) +- Fixed handling of \x0c whitespace character (Issue #811) +- Improved CLI documentation ### 4.3.14 - March 9, 2019 - hot fix release - Fixed a regression with */directory/*.py style patterns diff --git a/isort/isort.py b/isort/isort.py index 8968d5df..5757c009 100644 --- a/isort/isort.py +++ b/isort/isort.py @@ -192,8 +192,8 @@ class SortImports(object): check_output = self.output check_against = file_contents if self.config['ignore_whitespace']: - check_output = check_output.replace(self.line_separator, "").replace(" ", "") - check_against = check_against.replace(self.line_separator, "").replace(" ", "") + check_output = check_output.replace(self.line_separator, "").replace(" ", "").replace("\x0c", "") + check_against = check_against.replace(self.line_separator, "").replace(" ", "").replace("\x0c", "") if check_output.strip() == check_against.strip(): if self.config['verbose']: diff --git a/test_isort.py b/test_isort.py index b6f07e62..e6fe576e 100644 --- a/test_isort.py +++ b/test_isort.py @@ -2910,3 +2910,16 @@ def test_to_ensure_empty_line_not_added_to_file_start_issue_889(): '# comment2\n' 'import sys\n') assert SortImports(file_contents=test_input).output == test_input + + +def test_to_ensure_correctly_handling_of_whitespace_only_issue_811(capsys): + test_input = ('import os\n' + 'import sys\n' + '\n' + '\x0c\n' + 'def my_function():\n' + ' print("hi")\n') + SortImports(file_contents=test_input, ignore_whitespace=True) + out, err = capsys.readouterr() + assert out == '' + assert err == '' |