diff options
| author | Yuri Volchkov <yuri@volch.org> | 2021-02-05 11:22:54 +0100 |
|---|---|---|
| committer | Yuri Volchkov <yuri.volchkov@gmail.com> | 2021-02-05 12:09:10 +0100 |
| commit | af86f05d11c3613a418f7d3babfdc618e1cac805 (patch) | |
| tree | 2baaca8c051eedd2f8d8164c9b053895fb3ba5f0 | |
| parent | 3c19a6e1004bb8c116bfc7823477118490a2eef6 (diff) | |
| download | gitpython-af86f05d11c3613a418f7d3babfdc618e1cac805.tar.gz | |
Fix inheritance issue at commit.iter_items
The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.
Signed-off-by: Yuri Volchkov <yuri@volch.org>
| -rw-r--r-- | git/objects/commit.py | 2 | ||||
| -rw-r--r-- | test/test_commit.py | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/git/objects/commit.py b/git/objects/commit.py index 8a84dd69..302798cb 100644 --- a/git/objects/commit.py +++ b/git/objects/commit.py @@ -269,7 +269,7 @@ class Commit(base.Object, Iterable, Diffable, Traversable, Serializable): # END handle extra info assert len(hexsha) == 40, "Invalid line: %s" % hexsha - yield Commit(repo, hex_to_bin(hexsha)) + yield cls(repo, hex_to_bin(hexsha)) # END for each line in stream # TODO: Review this - it seems process handling got a bit out of control # due to many developers trying to fix the open file handles issue diff --git a/test/test_commit.py b/test/test_commit.py index 0292545f..7260a233 100644 --- a/test/test_commit.py +++ b/test/test_commit.py @@ -199,6 +199,13 @@ class TestCommit(TestCommitSerialization): less_ltd_commits = list(Commit.iter_items(self.rorepo, 'master', paths=('CHANGES', 'AUTHORS'))) assert len(ltd_commits) < len(less_ltd_commits) + class Child(Commit): + def __init__(self, *args, **kwargs): + super(Child, self).__init__(*args, **kwargs) + + child_commits = list(Child.iter_items(self.rorepo, 'master', paths=('CHANGES', 'AUTHORS'))) + assert type(child_commits[0]) == Child + def test_iter_items(self): # pretty not allowed self.assertRaises(ValueError, Commit.iter_items, self.rorepo, 'master', pretty="raw") |