summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksander Nitecki <ixendr@itogi.re>2016-05-26 23:51:19 +0200
committerAleksander Nitecki <ixendr@itogi.re>2016-05-26 23:51:19 +0200
commit39164b038409cb66960524e19f60e83d68790325 (patch)
tree569fb9f14cd219345bd2107c95f29ba9a04761df
parent902679c47c3d1238833ac9c9fdbc7c0ddbedf509 (diff)
downloadgitpython-39164b038409cb66960524e19f60e83d68790325.tar.gz
Use proper syntax for conditional expression
(instead of abusing the "short-circuit" property of logical operations)
-rw-r--r--git/cmd.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/git/cmd.py b/git/cmd.py
index 0c3cc8ca..c29e3485 100644
--- a/git/cmd.py
+++ b/git/cmd.py
@@ -609,7 +609,7 @@ class Git(LazyMixin):
bufsize=-1,
stdin=istream,
stderr=PIPE,
- stdout=with_stdout and PIPE or open(os.devnull, 'wb'),
+ stdout=PIPE if with_stdout else open(os.devnull, 'wb'),
shell=self.USE_SHELL,
close_fds=(os.name == 'posix'), # unsupported on windows
universal_newlines=universal_newlines,