summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Thiel <byronimo@gmail.com>2017-02-25 10:38:43 +0100
committerGitHub <noreply@github.com>2017-02-25 10:38:43 +0100
commit2ede752333a851ee6ad9ec2260a0fb3e4f3c1b0b (patch)
treeed5ac5ef49987e8d2c3e94645dbf4c65247eb951
parent0181a40db75bb27277bec6e0802f09a45f84ffb3 (diff)
parent12db6bbe3712042c10383082a4c40702b800a36a (diff)
downloadgitpython-2ede752333a851ee6ad9ec2260a0fb3e4f3c1b0b.tar.gz
Merge pull request #582 from gitpython-developers/no_devnull_open
fix(cmd): checking process.DEVNUL were needlessly opening `os.devnull`
-rw-r--r--git/cmd.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/git/cmd.py b/git/cmd.py
index d28e0902..702733ea 100644
--- a/git/cmd.py
+++ b/git/cmd.py
@@ -581,7 +581,7 @@ class Git(LazyMixin):
stdout_sink = (PIPE
if with_stdout
- else getattr(subprocess, 'DEVNULL', open(os.devnull, 'wb')))
+ else getattr(subprocess, 'DEVNULL', None) or open(os.devnull, 'wb'))
log.debug("Popen(%s, cwd=%s, universal_newlines=%s, shell=%s)",
command, cwd, universal_newlines, shell)
try: