summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #1838 from python-gitlab/jlvillal/version_mvNejc Habjan2022-01-151-1/+1
|\ | | | | chore: rename `gitlab/__version__.py` to `gitlab/_version.py`
| * chore: rename `gitlab/__version__.py` -> `gitlab/_version.py`jlvillal/version_mvJohn L. Villalovos2022-01-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It is confusing to have a `gitlab/__version__.py` because we also create a variable `gitlab.__version__` which can conflict with `gitlab/__version__.py`. For example in `gitlab/const.py` we have to know that `gitlab.__version__` is a module and not the variable due to the ordering of imports. But in most other usage `gitlab.__version__` is a version string. To reduce confusion make the name of the version file `gitlab/_version.py`.
* | test: use 'responses' in test_mixins_methods.pyJohn L. Villalovos2022-01-141-146/+191
| | | | | | | | | | | | Convert from httmock to responses in test_mixins_methods.py This leaves only one file left to convert
* | chore(tests): use method `projects.transfer()`jlvillal/catch_warningsJohn L. Villalovos2022-01-131-2/+2
|/ | | | | | When doing the functional tests use the new function `projects.transfer` instead of the deprecated function `projects.transfer_project()`
* test(groups): enable group transfer testsNejc Habjan2022-01-133-10/+11
|
* feat(api): add `project.transfer()` and deprecate `transfer_project()`Nejc Habjan2022-01-134-5/+78
|
* Merge pull request #1819 from python-gitlab/jlvillal/encoded_idNejc Habjan2022-01-136-15/+134
|\ | | | | fix: use url-encoded ID in all paths
| * chore: replace usage of utils._url_encode() with utils.EncodedId()jlvillal/encoded_idJohn L. Villalovos2022-01-132-24/+3
| | | | | | | | | | | | utils.EncodedId() has basically the same functionalityy of using utils._url_encode(). So remove utils._url_encode() as we don't need it.
| * chore: add EncodedId string class to use to hold URL-encoded pathsJohn L. Villalovos2022-01-136-2/+113
| | | | | | | | | | | | | | | | | | Add EncodedId string class. This class returns a URL-encoded string but ensures it will only URL-encode it once even if recursively called. Also added some functional tests of 'lazy' objects to make sure they work.
| * fix: use url-encoded ID in all pathsJohn L. Villalovos2022-01-132-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | Make sure all usage of the ID in the URL path is encoded. Normally it isn't an issue as most IDs are integers or strings which don't contain a slash ('/'). But when the ID is a string with a slash character it will break things. Add a test case that shows this fixes wikis issue with subpages which use the slash character. Closes: #1079
* | Merge pull request #1827 from python-gitlab/jlvillal/all_objectsNejc Habjan2022-01-131-0/+28
|\ \ | |/ |/| fix: members: use new *All objects for *AllManager managers
| * fix(members): use new *All objects for *AllManager managersJohn L. Villalovos2022-01-131-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change it so that: GroupMemberAllManager uses GroupMemberAll object ProjectMemberAllManager uses ProjectMemberAll object Create GroupMemberAll and ProjectMemberAll objects that do not support any Mixin type methods. Previously we were using GroupMember and ProjectMember which support the `save()` and `delete()` methods but those methods will not work with objects retrieved using the `/members/all/` API calls. `list()` API calls: [1] GET /groups/:id/members/all GET /projects/:id/members/all `get()` API calls: [2] GET /groups/:id/members/all/:user_id GET /projects/:id/members/all/:user_id Closes: #1825 Closes: #848 [1] https://docs.gitlab.com/ee/api/members.html#list-all-members-of-a-group-or-project-including-inherited-and-invited-members [2] https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project-including-inherited-and-invited-members
* | fix(api): services: add missing `lazy` parameterjlvillal/lazy_serviceJohn L. Villalovos2022-01-131-0/+11
|/ | | | | | | | Commit 8da0b758c589f608a6ae4eeb74b3f306609ba36d added the `lazy` parameter to the services `get()` method but missed then using the `lazy` parameter when it called `super(...).get(...)` Closes: #1828
* feat: add support for Group Access Token APIFabio Huser2022-01-091-0/+113
| | | | See https://docs.gitlab.com/ee/api/group_access_tokens.html
* docs: update project access token API reference linkFabio Huser2022-01-091-1/+1
|
* Merge pull request #1812 from python-gitlab/jlvillal/pprintNejc Habjan2022-01-091-0/+30
|\ | | | | chore: add `pprint()` and `pformat()` methods to RESTObject
| * chore: add `pprint()` and `pformat()` methods to RESTObjectJohn L. Villalovos2022-01-081-0/+30
| | | | | | | | | | This is useful in debugging and testing. As can easily print out the values from an instance in a more human-readable form.
* | Merge pull request #1786 from python-gitlab/jlvillal/loggingNejc Habjan2022-01-091-16/+46
|\ \ | | | | | | test: add logging to `tests/functional/conftest.py`
| * | chore: add logging to `tests/functional/conftest.py`John L. Villalovos2022-01-081-16/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have found trying to debug issues in the functional tests can be difficult. Especially when trying to figure out failures in the CI running on Github. Add logging to `tests/functional/conftest.py` to have a better understanding of what is happening during a test run which is useful when trying to troubleshoot issues in the CI.
* | | fix: remove custom URL encodingJohn L. Villalovos2022-01-082-6/+15
|/ / | | | | | | | | | | | | | | | | | | We were using `str.replace()` calls to take care of URL encoding issues. Switch them to use our `utils._url_encode()` function which itself uses `urllib.parse.quote()` Closes: #1356
* | fix: remove default arguments for mergerequests.merge()John L. Villalovos2022-01-081-1/+3
| | | | | | | | | | | | | | | | | | | | The arguments `should_remove_source_branch` and `merge_when_pipeline_succeeds` are optional arguments. We should not be setting any default value for them. https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr Closes: #1750
* | fix(cli): url-encode path components of the URLJohn L. Villalovos2022-01-083-11/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | In the CLI we need to make sure the components put into the path portion of the URL are url-encoded. Otherwise they will be interpreted as part of the path. For example can specify the project ID as a path, but in the URL it must be url-encoded or it doesn't work. Also stop adding the components of the path as query parameters in the URL. Closes: #783 Closes: #1498
* | chore: fix functional test failure if config presentJohn L. Villalovos2022-01-081-5/+4
|/ | | | | Previously c8256a5933d745f70c7eea0a7d6230b51bac0fbc was done to fix this but it missed two other failures.
* chore: add functional test of mergerequest.get()jlvillal/test_1425John L. Villalovos2022-01-031-0/+16
| | | | | | | Add a functional test of test mergerequest.get() and mergerequest.get(..., lazy=True) Closes: #1425
* chore: add test case to show branch name with period worksjlvillal/dot_branchJohn L. Villalovos2022-01-031-0/+17
| | | | | | | Add a test case to show that a branch name with a period can be fetched with a `get()` Closes: #1715
* feat(cli): allow options from args and environment variablesNejc Habjan2022-01-023-11/+184
| | | | | | | | BREAKING-CHANGE: The gitlab CLI will now accept CLI arguments and environment variables for its global options in addition to configuration file options. This may change behavior for some workflows such as running inside GitLab CI and with certain environment variables configured.
* chore: fix functional test failure if config presentjlvillal/cli_testJohn L. Villalovos2022-01-011-4/+8
| | | | | | | Fix functional test failure if config present and configured with token. Closes: #1791
* fix: handle situation where GitLab does not return valuesjlvillal/paginationJohn L. Villalovos2021-12-301-3/+2
| | | | | | | | | | | | | | | | If a query returns more than 10,000 records than the following values are NOT returned: x.total_pages x.total Modify the code to allow no value to be set for these values. If there is not a value returned the functions will now return None. Update unit test so no longer `xfail` https://docs.gitlab.com/ee/user/gitlab_com/index.html#pagination-response-headers Closes #1686
* test: reproduce missing pagination headers in testsNejc Habjan2021-12-301-0/+30
|
* test: drop httmock dependency in test_gitlab.pyNejc Habjan2021-12-301-45/+61
|
* chore: ensure reset_gitlab() succeedsJohn L. Villalovos2021-12-281-0/+30
| | | | | | | | | Ensure reset_gitlab() succeeds by waiting to make sure everything has been deleted as expected. If the timeout is exceeded fail the test. Not using `wait_for_sidekiq` as it didn't work. During testing I didn't see any sidekiq processes as being busy even though not everything was deleted.
* Merge pull request #1782 from python-gitlab/jlvillal/repository_func_testsNejc Habjan2021-12-281-0/+4
|\ | | | | chore: skip a functional test if not using >= py3.9
| * chore: skip a functional test if not using >= py3.9jlvillal/repository_func_testsJohn L. Villalovos2021-12-261-0/+4
| | | | | | | | | | One of the tests requires Python 3.9 or higher to run. Mark the test to be skipped if running Python less than 3.9.
* | chore: update version in docker-compose.ymljlvillal/docker_composeJohn L. Villalovos2021-12-261-1/+1
|/ | | | | | | | | | | When running with docker-compose on Ubuntu 20.04 I got the error: $ docker-compose up ERROR: The Compose file './docker-compose.yml' is invalid because: networks.gitlab-network value Additional properties are not allowed ('name' was unexpected) Changing the version in the docker-compose.yml file fro '3' to '3.5' resolved the issue.
* feat(api): support file format for repository archiveMax Ludwig2021-12-211-2/+25
|
* fix: stop encoding '.' to '%2E'jlvillal/leave_dotJohn L. Villalovos2021-12-204-24/+8
| | | | | | | | | | | | | | | | | | | | Forcing the encoding of '.' to '%2E' causes issues. It also goes against the RFC: https://datatracker.ietf.org/doc/html/rfc3986.html#section-2.3 From the RFC: For consistency, percent-encoded octets in the ranges of ALPHA (%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E), underscore (%5F), or tilde (%7E) should not be created by URI producers... Closes #1006 Related #1356 Related #1561 BREAKING CHANGE: stop encoding '.' to '%2E'. This could potentially be a breaking change for users who have incorrectly configured GitLab servers which don't handle period '.' characters correctly.
* chore: fix unit test if config file exists locallyjlvillal/unit_test_configJohn L. Villalovos2021-12-191-2/+4
| | | | Closes #1764
* feat(cli): do not require config file to run CLIfeat/cli-without-config-fileNejc Habjan2021-12-132-52/+127
| | | | | | | | | | | BREAKING CHANGE: A config file is no longer needed to run the CLI. python-gitlab will default to https://gitlab.com with no authentication if there is no config file provided. python-gitlab will now also only look for configuration in the provided PYTHON_GITLAB_CFG path, instead of merging it with user- and system-wide config files. If the environment variable is defined and the file cannot be opened, python-gitlab will now explicitly fail.
* test(api): fix current user mail count in newer gitlabNejc Habjan2021-12-111-2/+2
|
* chore(api): temporarily remove topic delete endpointNejc Habjan2021-12-113-23/+0
| | | | It is not yet available upstream.
* feat(api): add support for Topics APINejc Habjan2021-12-114-1/+143
|
* Merge pull request #1710 from python-gitlab/jlvillal/get_without_idNejc Habjan2021-12-111-19/+84
|\ | | | | chore: add get() methods for GetWithoutIdMixin based classes
| * chore: add get() methods for GetWithoutIdMixin based classesjlvillal/get_without_idJohn L. Villalovos2021-12-081-19/+84
| | | | | | | | | | | | | | Add the get() methods for the GetWithoutIdMixin based classes. Update the tests/meta/test_ensure_type_hints.py tests to check to ensure that the get methods are defined with the correct return type.
* | feat: add delete on package_file objectSimon Hébert-Deschamps2021-12-091-1/+34
|/
* chore: add running unit tests on windows/macosJohn L. Villalovos2021-12-071-0/+2
| | | | | Add running the unit tests on windows-latest and macos-latest with Python 3.10.
* Merge pull request #1702 from python-gitlab/jlvillal/attribute_helpNejc Habjan2021-12-011-0/+24
|\ | | | | chore: attempt to be more informative for missing attributes
| * chore: attempt to be more informative for missing attributesjlvillal/attribute_helpJohn L. Villalovos2021-11-301-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A commonly reported issue from users on Gitter is that they get an AttributeError for an attribute that should be present. This is often caused due to the fact that they used the `list()` method to retrieve the object and objects retrieved this way often only have a subset of the full data. Add more details in the AttributeError message that explains the situation to users. This will hopefully allow them to resolve the issue. Update the FAQ in the docs to add a section discussing the issue. Closes #1138
* | chore: use constants from gitlab.const moduleJohn L. Villalovos2021-11-304-11/+12
| | | | | | | | | | Have code use constants from the gitlab.const module instead of from the top-level gitlab module.
* | refactor: deprecate accessing constants from top-level namespaceJohn L. Villalovos2021-11-301-16/+31
|/ | | | | | | | | | | | | | We are planning on adding enumerated constants into gitlab/const.py, but if we do that than they will end up being added to the top-level gitlab namespace. We really want to get users to start using `gitlab.const.` to access the constant values in the future. Add the currently defined constants to a list that should not change. Use a module level __getattr__ function so that we can deprecate access to the top-level constants. Add a unit test which verifies we generate a warning when accessing the top-level constants.
* chore(tests): apply review suggestionsNejc Habjan2021-11-281-3/+3
|