summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | chore: attempt to be more informative for missing attributesjlvillal/attribute_helpJohn L. Villalovos2021-11-304-5/+71
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A commonly reported issue from users on Gitter is that they get an AttributeError for an attribute that should be present. This is often caused due to the fact that they used the `list()` method to retrieve the object and objects retrieved this way often only have a subset of the full data. Add more details in the AttributeError message that explains the situation to users. This will hopefully allow them to resolve the issue. Update the FAQ in the docs to add a section discussing the issue. Closes #1138
* | Merge pull request #1694 from python-gitlab/jlvillal/const_explicitNejc Habjan2021-12-0114-73/+140
|\ \ | |/ |/| refactor: explicitly import gitlab.const values into top-level namespace
| * docs: update docs to use gitlab.const for constantsjlvillal/const_explicitJohn L. Villalovos2021-11-307-50/+50
| | | | | | | | Update the docs to use gitlab.const to access constants.
| * chore: use constants from gitlab.const moduleJohn L. Villalovos2021-11-305-12/+13
| | | | | | | | | | Have code use constants from the gitlab.const module instead of from the top-level gitlab module.
| * refactor: deprecate accessing constants from top-level namespaceJohn L. Villalovos2021-11-303-17/+83
|/ | | | | | | | | | | | | | We are planning on adding enumerated constants into gitlab/const.py, but if we do that than they will end up being added to the top-level gitlab namespace. We really want to get users to start using `gitlab.const.` to access the constant values in the future. Add the currently defined constants to a list that should not change. Use a module level __getattr__ function so that we can deprecate access to the top-level constants. Add a unit test which verifies we generate a warning when accessing the top-level constants.
* Merge pull request #1721 from python-gitlab/test/cli-coverageNejc Habjan2021-11-2815-34/+104
|\ | | | | test(cli): improve basic CLI coverage
| * chore(tests): apply review suggestionsNejc Habjan2021-11-282-4/+4
| |
| * test(cli): improve basic CLI coveragetest/cli-coverageNejc Habjan2021-11-2715-33/+103
| |
* | chore(deps): update dependency sphinx to v4.3.1Renovate Bot2021-11-271-1/+1
| |
* | Merge pull request #1714 from python-gitlab/jlvillal/pytest_script_launch_modeNejc Habjan2021-11-271-4/+1
|\ \ | |/ |/| chore: remove pytest-console-scripts specific config
| * chore: remove pytest-console-scripts specific configJohn L. Villalovos2021-11-271-4/+1
|/ | | | | | | | | Remove the pytest-console-scripts specific config from the global '[pytest]' config section. Use the command line option `--script-launch-mode=subprocess` Closes #1713
* Merge pull request #1712 from StingRayZA/EpicnotesNejc Habjan2021-11-273-2/+96
|\ | | | | feat(api): add support for epic notes
| * feat(api): add support for epic notesRaimund Hook2021-11-253-2/+96
| | | | | | | | | | | | Added support for notes on group epics Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
* | Merge pull request #1718 from python-gitlab/jlvillal/project_groupsNejc Habjan2021-11-273-0/+42
|\ \ | | | | | | feat: add support for `projects.groups.list()`
| * | feat: add support for `projects.groups.list()`jlvillal/project_groupsJohn L. Villalovos2021-11-263-0/+42
|/ / | | | | | | | | | | Add support for `projects.groups.list()` endpoint. Closes #1717
* | chore(deps): update typing dependenciesRenovate Bot2021-11-262-4/+4
|/
* Merge pull request #1707 from python-gitlab/jlvillal/reduce_meta_testsNejc Habjan2021-11-242-22/+7
|\ | | | | chore: remove duplicate/no-op tests from meta/test_ensure_type_hints
| * chore: remove duplicate/no-op tests from meta/test_ensure_type_hintsJohn L. Villalovos2021-11-242-22/+7
|/ | | | | | | | | | | | | | | | | | | | | | | Before we were generating 725 tests for the meta/test_ensure_type_hints.py tests. Which isn't a huge concern as it was fairly fast. But when we had a failure we would usually get two failures for each problem as the same test was being run multiple times. Changed it so that: 1. Don't add tests that are not for *Manager classes 2. Use a set so that we don't have duplicate tests. After doing that our generated test count in meta/test_ensure_type_hints.py went from 725 to 178 tests. Additionally removed the parsing of `pyproject.toml` to generate files to ignore as we have finished adding type-hints to all files in gitlab/v4/objects/. This also means we no longer use the toml library so remove installation of `types-toml`. To determine the test count the following command was run: $ tox -e py39 -- -k test_ensure_type_hints
* Merge pull request #1695 from python-gitlab/jlvillal/mypy_epicsNejc Habjan2021-11-2313-90/+353
|\ | | | | chore: add type-hints to remaining gitlab/v4/objects/*.py files
| * chore: add type-hints to gitlab/v4/objects/files.pyjlvillal/mypy_epicsJohn L. Villalovos2021-11-212-13/+58
| |
| * chore: add type-hints to gitlab/v4/objects/labels.pyJohn L. Villalovos2021-11-212-7/+37
| |
| * chore: add type-hints to gitlab/v4/objects/sidekiq.pyJohn L. Villalovos2021-11-212-5/+12
| |
| * chore: add type-hints to gitlab/v4/objects/services.pyJohn L. Villalovos2021-11-212-6/+15
| |
| * chore: add type-hints to gitlab/v4/objects/repositories.pyJohn L. Villalovos2021-11-212-14/+48
| |
| * chore: add type-hints to gitlab/v4/objects/pipelines.pyJohn L. Villalovos2021-11-212-7/+30
| |
| * chore: add type-hints to gitlab/v4/objects/milestones.pyJohn L. Villalovos2021-11-212-5/+22
| |
| * chore: add type-hints to gitlab/v4/objects/jobs.pyJohn L. Villalovos2021-11-212-15/+55
| |
| * chore: add type-hints to gitlab/v4/objects/issues.pyJohn L. Villalovos2021-11-212-7/+33
| |
| * chore: add type-hints to gitlab/v4/objects/geo_nodes.pyJohn L. Villalovos2021-11-212-8/+23
| |
| * chore: add type-hints to gitlab/v4/objects/epics.pyJohn L. Villalovos2021-11-212-3/+16
| |
| * chore: fix issue with adding type-hints to 'manager' attributeJohn L. Villalovos2021-11-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | When attempting to add type-hints to the the 'manager' attribute into a RESTObject derived class it would break things. This was because our auto-manager creation code would automatically add the specified annotated manager to the 'manager' attribute. This breaks things. Now check in our auto-manager creation if our attribute is called 'manager'. If so we ignore it.
* | Merge pull request #1705 from python-gitlab/jlvillal/drop_py_36Nejc Habjan2021-11-234-6/+3
|\ \ | | | | | | feat: remove support for Python 3.6, require 3.7 or higher
| * | feat: remove support for Python 3.6, require 3.7 or higherJohn L. Villalovos2021-11-234-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python 3.6 is End-of-Life (EOL) as of 2021-12 as stated in https://www.python.org/dev/peps/pep-0494/ By dropping support for Python 3.6 and requiring Python 3.7 or higher it allows python-gitlab to take advantage of new features in Python 3.7, which are documented at: https://docs.python.org/3/whatsnew/3.7.html Some of these new features that may be useful to python-gitlab are: * PEP 563, postponed evaluation of type annotations. * dataclasses: PEP 557 – Data Classes * importlib.resources * PEP 562, customization of access to module attributes. * PEP 560, core support for typing module and generic types. * PEP 565, improved DeprecationWarning handling BREAKING CHANGE: As of python-gitlab 3.0.0, Python 3.6 is no longer supported. Python 3.7 or higher is required.
* | | chore(deps): update dependency types-setuptools to v57.4.3Renovate Bot2021-11-232-2/+2
| | |
* | | chore(deps): update dependency black to v21Renovate Bot2021-11-221-1/+1
| | |
* | | Merge pull request #1693 from python-gitlab/jlvillay/mypy_test_metaNejc Habjan2021-11-234-6/+8
|\ \ \ | | | | | | | | chore: enable mypy for tests/meta/*
| * | | chore: enable mypy for tests/meta/*jlvillay/mypy_test_metaJohn L. Villalovos2021-11-164-6/+8
| | | |
* | | | chore: have renovate upgrade black version (#1700)John Villalovos2021-11-232-2/+11
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renovate is not upgrading the `black` package. There is an open issue[1] about this. Also change .commitlintrc.json to allow 200 character footer lines in the commit message. Otherwise would be forced to split the URL across multiple lines making it un-clickable :( Use suggested work-arounds from: https://github.com/renovatebot/renovate/issues/7167#issuecomment-904106838 https://github.com/scop/bash-completion/blob/e7497f6ee8232065ec11450a52a1f244f345e2c6/renovate.json#L34-L38 [1] https://github.com/renovatebot/renovate/issues/7167
* | | Merge pull request #1701 from python-gitlab/jlvillal/func_testNejc Habjan2021-11-221-0/+4
|\ \ \ | |_|/ |/| | chore: correct test_groups.py test
| * | chore: correct test_groups.py testjlvillal/func_testJohn L. Villalovos2021-11-191-0/+4
|/ / | | | | | | | | | | | | | | | | The test was checking twice if the same group3 was not in the returned list. Should have been checking for group3 and group4. Also added a test that only skipped one group and checked that the group was not in the returned list and a non-skipped group was in the list.
* | Merge pull request #1696 from ↵Nejc Habjan2021-11-172-12/+35
|\ \ | |/ |/| | | | | python-gitlab/jlvillal/mypy_merge_request_approvals chore: add type-hints to gitlab/v4/objects/merge_request_approvals.py
| * chore: add type-hints to gitlab/v4/objects/merge_request_approvals.pyjlvillal/mypy_merge_request_approvalsJohn L. Villalovos2021-11-162-12/+35
|/
* Merge pull request #1692 from python-gitlab/jlvillal/mypy_setupNejc Habjan2021-11-161-1/+0
|\ | | | | chore: check setup.py with mypy
| * chore: check setup.py with mypyJohn L. Villalovos2021-11-161-1/+0
|/ | | | | | | | Prior commit 06184daafd5010ba40bb39a0768540b7e98bd171 fixed the type-hints for setup.py. But missed removing 'setup' from the exclude list in pyproject.toml for mypy checks. Remove 'setup' from the exclude list in pyproject.toml from mypy checks.
* Merge pull request #1681 from python-gitlab/jlvillal/mypy_ensure_type_hintsNejc Habjan2021-11-1625-6/+437
|\ | | | | Ensure get() methods have correct type-hints
| * chore: ensure get() methods have correct type-hintsjlvillal/mypy_ensure_type_hintsJohn L. Villalovos2021-11-1521-4/+434
| | | | | | | | | | | | | | | | Fix classes which don't have correct 'get()' methods for classes derived from GetMixin. Add a unit test which verifies that classes have the correct return type in their 'get()' method.
| * chore: create a 'tests/meta/' directory and put test_mro.py in itJohn L. Villalovos2021-11-154-2/+3
| | | | | | | | | | The 'test_mro.py' file is not really a unit test but more of a 'meta' check on the validity of the code base.
* | Merge pull request #1683 from python-gitlab/jlvillal/mypy_setupNejc Habjan2021-11-153-2/+7
|\ \ | |/ | | chore: add type-hints to setup.py and check with mypy
| * chore: add type-hints to setup.py and check with mypyjlvillal/mypy_setupJohn L. Villalovos2021-11-143-2/+7
|/
* Merge pull request #1691 from python-gitlab/jlvillal/mypy_snippetsNejc Habjan2021-11-142-5/+32
|\ | | | | chore: add type-hints to gitlab/v4/objects/snippets.py