diff options
| author | John L. Villalovos <john@sodarock.com> | 2022-01-15 08:31:00 -0800 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2022-01-15 08:31:00 -0800 |
| commit | b981ce7fed88c5d86a3fffc4ee3f99be0b958c1d (patch) | |
| tree | 9e8e41154f80a3408972cece6fc4328c8186e455 /gitlab | |
| parent | cbbe7ce61db0649be286c5c1a239e00ed86f8039 (diff) | |
| download | gitlab-jlvillal/version_mv.tar.gz | |
chore: rename `gitlab/__version__.py` -> `gitlab/_version.py`jlvillal/version_mv
It is confusing to have a `gitlab/__version__.py` because we also
create a variable `gitlab.__version__` which can conflict with
`gitlab/__version__.py`.
For example in `gitlab/const.py` we have to know that
`gitlab.__version__` is a module and not the variable due to the
ordering of imports. But in most other usage `gitlab.__version__` is a
version string.
To reduce confusion make the name of the version file
`gitlab/_version.py`.
Diffstat (limited to 'gitlab')
| -rw-r--r-- | gitlab/__init__.py | 2 | ||||
| -rw-r--r-- | gitlab/_version.py (renamed from gitlab/__version__.py) | 0 | ||||
| -rw-r--r-- | gitlab/const.py | 2 |
3 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/__init__.py b/gitlab/__init__.py index 824f177..5f168ac 100644 --- a/gitlab/__init__.py +++ b/gitlab/__init__.py @@ -20,7 +20,7 @@ import warnings from typing import Any import gitlab.config # noqa: F401 -from gitlab.__version__ import ( # noqa: F401 +from gitlab._version import ( # noqa: F401 __author__, __copyright__, __email__, diff --git a/gitlab/__version__.py b/gitlab/_version.py index a1fb3cd..a1fb3cd 100644 --- a/gitlab/__version__.py +++ b/gitlab/_version.py diff --git a/gitlab/const.py b/gitlab/const.py index 48aa96d..2ed4fa7 100644 --- a/gitlab/const.py +++ b/gitlab/const.py @@ -15,7 +15,7 @@ # You should have received a copy of the GNU Lesser General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -from gitlab.__version__ import __title__, __version__ +from gitlab._version import __title__, __version__ # NOTE(jlvillal): '_DEPRECATED' only affects users accessing constants via the # top-level gitlab.* namespace. See 'gitlab/__init__.py:__getattr__()' for the |