fix: use the [] after key names for array variablesjlvillal/arrays

1. Create a new CommaSeparatedListAttribute class. This is to indicate
   types which are sent to the GitLab server as
   comma-separated-strings (CSV) but we have been allowing users to
   use a list-of-strings.  These values are NOT array values, so
   adding [] to the key name breaks them.

2. Rename ListAttribute to ArrayAttribute.

3. If a value is of type ArrayAttribute then append '[]' to the name
   of the value.

4. Move processing of most GitlabAttributes into the
   client.py:http_request() method. Now we convert our params into a
   list of tuples so that we can have multiple identical keys but with
   different values.

Fixes: #1698

1 files changed, 2 insertions, 2 deletions

diff --git a/gitlab/v4/objects/milestones.py b/gitlab/v4/objects/milestones.py
index 6b1e28d..da75826 100644
--- a/gitlab/v4/objects/milestones.py
+++ b/gitlab/v4/objects/milestones.py
@@ -93,7 +93,7 @@ class GroupMilestoneManager(CRUDMixin, RESTManager):
         optional=("title", "description", "due_date", "start_date", "state_event"),
     )
     _list_filters = ("iids", "state", "search")
-    _types = {"iids": types.ListAttribute}
+    _types = {"iids": types.ArrayAttribute}
 
     def get(
         self, id: Union[str, int], lazy: bool = False, **kwargs: Any
@@ -177,7 +177,7 @@ class ProjectMilestoneManager(CRUDMixin, RESTManager):
         optional=("title", "description", "due_date", "start_date", "state_event"),
     )
     _list_filters = ("iids", "state", "search")
-    _types = {"iids": types.ListAttribute}
+    _types = {"iids": types.ArrayAttribute}
 
     def get(
         self, id: Union[str, int], lazy: bool = False, **kwargs: Any