diff options
| author | John L. Villalovos <john@sodarock.com> | 2022-01-09 00:53:12 -0800 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2022-01-09 00:53:12 -0800 |
| commit | 99e1f8bad3e52ca6fb2dc6b876a262c6fee39e41 (patch) | |
| tree | 6a11bdaf3e49a3dec844255d74a860798e8acc68 /gitlab/v4/objects/issues.py | |
| parent | ac812727c26c9bde4ee5c1115029f2ff4ab1964b (diff) | |
| download | gitlab-jlvillal/encoded_id_alt.tar.gz | |
fix: use url-encoded ID in all paths ALTERNATE METHODjlvillal/encoded_id_alt
An alternative to https://github.com/python-gitlab/python-gitlab/pull/1819
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079
Diffstat (limited to 'gitlab/v4/objects/issues.py')
| -rw-r--r-- | gitlab/v4/objects/issues.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py index 5a99a09..585e02e 100644 --- a/gitlab/v4/objects/issues.py +++ b/gitlab/v4/objects/issues.py @@ -132,7 +132,7 @@ class ProjectIssue( GitlabAuthenticationError: If authentication is not correct GitlabUpdateError: If the issue could not be moved """ - path = f"{self.manager.path}/{self.get_id()}/move" + path = f"{self.manager.path}/{self.encoded_id}/move" data = {"to_project_id": to_project_id} server_data = self.manager.gitlab.http_post(path, post_data=data, **kwargs) if TYPE_CHECKING: @@ -154,7 +154,7 @@ class ProjectIssue( Returns: The list of merge requests. """ - path = f"{self.manager.path}/{self.get_id()}/related_merge_requests" + path = f"{self.manager.path}/{self.encoded_id}/related_merge_requests" result = self.manager.gitlab.http_get(path, **kwargs) if TYPE_CHECKING: assert isinstance(result, dict) @@ -175,7 +175,7 @@ class ProjectIssue( Returns: The list of merge requests. """ - path = f"{self.manager.path}/{self.get_id()}/closed_by" + path = f"{self.manager.path}/{self.encoded_id}/closed_by" result = self.manager.gitlab.http_get(path, **kwargs) if TYPE_CHECKING: assert isinstance(result, dict) |