summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2021-04-18 10:47:06 -0700
committerJohn L. Villalovos <john@sodarock.com>2021-04-18 10:47:06 -0700
commit062f8f6a917abc037714129691a845c16b070ff6 (patch)
tree01297f1819ee80a3c840ece9fcaf34143a1b0e5e
parent916a7fe4661b3822a0a93fc75fb72d80f550582d (diff)
downloadgitlab-062f8f6a917abc037714129691a845c16b070ff6.tar.gz
fix: argument type was not a tuple as expected
While adding type-hints mypy flagged this as an issue. The third argument to register_custom_action is supposed to be a tuple. It was being passed as a string rather than a tuple of strings.
-rw-r--r--gitlab/v4/objects/merge_requests.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitlab/v4/objects/merge_requests.py b/gitlab/v4/objects/merge_requests.py
index 938cb5a..83e8f44 100644
--- a/gitlab/v4/objects/merge_requests.py
+++ b/gitlab/v4/objects/merge_requests.py
@@ -234,7 +234,7 @@ class ProjectMergeRequest(
path = "%s/%s/pipelines" % (self.manager.path, self.get_id())
return self.manager.gitlab.http_get(path, **kwargs)
- @cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha"))
+ @cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha",))
@exc.on_http_error(exc.GitlabMRApprovalError)
def approve(self, sha=None, **kwargs):
"""Approve the merge request.