Made sure xrange is used instead of range in python 2

range in py2 will return a list, which can mean a lot of time and memory
is spent on generating it even though it's just used for iteration.

Simplified implementation of MAXSIZE

3 files changed, 7 insertions, 4 deletions

diff --git a/gitdb/test/db/lib.py b/gitdb/test/db/lib.py
index 38747de..8e333dd 100644
--- a/gitdb/test/db/lib.py
+++ b/gitdb/test/db/lib.py
@@ -22,6 +22,7 @@ from gitdb.base import (
 from gitdb.exc import BadObject
 from gitdb.typ import str_blob_type
 from gitdb.utils.encoding import force_bytes
+from gitdb.utils.compat import xrange
 
 from async import IteratorReader
 
@@ -43,7 +44,7 @@ class TestDBBase(TestBase):
         # write a bunch of objects and query their streams and info
         null_objs = db.size()
         ni = 250
-        for i in range(ni):
+        for i in xrange(ni):
             data = pack(">L", i)
             istream = IStream(str_blob_type, len(data), BytesIO(data))
             new_istream = db.store(istream)
@@ -131,7 +132,7 @@ class TestDBBase(TestBase):
         """Test generic object writing using asynchronous access"""
         ni = 5000
         def istream_generator(offset=0, ni=ni):
-            for data_src in range(ni):
+            for data_src in xrange(ni):
                 data = bytes(data_src + offset)
                 yield IStream(str_blob_type, len(data), BytesIO(data))
             # END for each item
diff --git a/gitdb/test/lib.py b/gitdb/test/lib.py
index 75342f1..d692224 100644
--- a/gitdb/test/lib.py
+++ b/gitdb/test/lib.py
@@ -12,6 +12,7 @@ from gitdb.stream import (
 )
 
 from gitdb.util import zlib
+from gitdb.utils.compat import xrange
 
 import sys
 import random
@@ -110,7 +111,7 @@ def make_bytes(size_in_bytes, randomize=False):
     """:return: string with given size in bytes
     :param randomize: try to produce a very random stream"""
     actual_size = size_in_bytes // 4
-    producer = range(actual_size)
+    producer = xrange(actual_size)
     if randomize:
         producer = list(producer)
         random.shuffle(producer)
diff --git a/gitdb/test/test_pack.py b/gitdb/test/test_pack.py
index bcda3cf..6b67ad8 100644
--- a/gitdb/test/test_pack.py
+++ b/gitdb/test/test_pack.py
@@ -26,6 +26,7 @@ from gitdb.base import (
 from gitdb.fun import delta_types
 from gitdb.exc import UnsupportedOperation
 from gitdb.util import to_bin_sha
+from gitdb.utils.compat import xrange
 from itertools import chain
 
 try:
@@ -64,7 +65,7 @@ class TestPack(TestBase):
         assert len(index.offsets()) == size
 
         # get all data of all objects
-        for oidx in range(index.size()):
+        for oidx in xrange(index.size()):
             sha = index.sha(oidx)
             assert oidx == index.sha_to_index(sha)