summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Allow noqa to apply to lines due to continuationnoqa_continuationAnthony Sottile2020-03-175-30/+122
|
* Merge branch 'upgrade_pip_no_get_pip' into 'master'Anthony Sottile2020-01-271-2/+1
|\ | | | | | | | | Upgrade pip in gitlab ci without using get-pip.py See merge request pycqa/flake8!411
| * Upgrade pip in gitlab ci without using get-pip.pyAnthony Sottile2020-01-271-2/+1
|/
* Merge branch 'config-appdirs' into 'master'Anthony Sottile2020-01-213-38/+24
|\ | | | | | | | | config: Determine path to user configuration immediately See merge request pycqa/flake8!409
| * config: Determine path to user configuration immediatelyEric N. Vander Weele2020-01-203-38/+24
|/ | | | | | | | | | | | | | | Preemptively determine the path of the user configuration file during the construction of the `ConfigFileFinder` object. The user configuration path will always be the same, regardless of when it gets obtained by a run of `flake8`. This isolates the logic of determining the user configuration path into a static helper method to be called to set the `.user_config_file` attribute. The helper method leverages `utils.is_windows()`, instead of reimplementing the check, and decomposes clearly the directory name and the base name to construct the path with a single `return` path. Additionally, this avoids reconstructing the path on demand of obtaining the user configuration file path.
* Merge branch 'config-remove-config-caching' into 'master'Anthony Sottile2020-01-202-54/+13
|\ | | | | | | | | config: Remove checks for configs being previously parsed See merge request pycqa/flake8!408
| * config: Remove checks for configs being previously parsedEric N. Vander Weele2020-01-202-54/+13
|/ | | | | | Remove the checks to see if a configuration file has already been seen and parsed. These checks aren't necessary because the entire run of `flake8` calls these methods *only* once per configuration provided.
* Merge branch 'file_not_found_error' into 'master'Anthony Sottile2020-01-163-6/+14
|\ | | | | | | | | | | | | Ensure that a not-found file produces an error Closes #600 See merge request pycqa/flake8!404
| * Ensure that a not-found file produces an errorAnthony Sottile2020-01-163-6/+14
| | | | | | | | - this restores a flake8 2.x behaviour that was lost in the refactor
* | Merge branch 'document_before_after' into 'master'Anthony Sottile2020-01-161-0/+11
|\ \ | | | | | | | | | | | | | | | | | | document that contents may appear before/after a noqa comment Closes #528 See merge request pycqa/flake8!407
| * | document that contents may appear before/after a noqa commentAnthony Sottile2020-01-161-0/+11
| |/
* | Merge branch 'form_feed_difference' into 'master'Anthony Sottile2020-01-164-29/+47
|\ \ | | | | | | | | | | | | | | | | | | split lines the same when read from stdin Closes #270 See merge request pycqa/flake8!406
| * | split lines the same when read from stdinAnthony Sottile2020-01-164-29/+47
| |/
* | Merge branch 'warning_contains_option' into 'master'Anthony Sottile2020-01-161-1/+2
|\ \ | | | | | | | | | | | | Fix the type= warning to contain the option name See merge request pycqa/flake8!405
| * | Fix the type= warning to contain the option nameAnthony Sottile2020-01-161-1/+2
| |/
* | Merge branch 'typo_fixes' into 'master'Anthony Sottile2020-01-161-2/+2
|\ \ | |/ |/| | | | | Some typo fixes in git hooks docs See merge request pycqa/flake8!403
| * Some typo fixes in git hooks docsSorin Sbarnea2020-01-161-2/+2
|/
* Merge branch 'config-finder-extra-files-optional' into 'master'Anthony Sottile2020-01-136-22/+17
|\ | | | | | | | | config: Make ConfigFileFinder 'extra_config_files' parameter optional See merge request pycqa/flake8!402
| * config: Make ConfigFileFinder 'extra_config_files' parameter optionalEric N. Vander Weele2020-01-126-22/+17
|/ | | | | This simplifies the number of required parameters needed for the `ConfigFileFinder` object throughout the various tests.
* Merge branch 'config-finder-config-file' into 'master'Anthony Sottile2020-01-139-48/+66
|\ | | | | | | | | Determine config file override from the ConfigFileFinder object See merge request pycqa/flake8!401
| * Remove unused 'cli_config' parameterEric N. Vander Weele2020-01-128-35/+19
| | | | | | | | | | | | Now that `ConfigFileFinder.config_file` attribute is used everywhere and is constructed from the `--config` CLI option, the now unused `cli_config` parameters can be safely removed.
| * config: Switch code paths to use 'ConfigFileFinder.config_file'Eric N. Vander Weele2020-01-124-12/+19
| | | | | | | | | | | | | | | | Now that the `ConfigFileFinder` has the `.config_file` attribute, switch the relevant code paths to utilize this public attribute. Tests have been updated to either construct `ConfigFileFinder` or mock the object appropriately.
| * config: Add 'config_file' parameter to ConfigFileFinderEric N. Vander Weele2020-01-123-3/+30
|/ | | | | | | | | The `--config` flag is passed into `MergedConfigParser.parse()` and the module-level function `config.get_local_plugins()`. Since both of these places utilize the `ConfigFileFinder` object and the configuration file override pertains to how configuration behaves, this incremental change directly associates the `ConfigFileFinder` and the configuration file override.
* Merge branch 'config-remove-parent-tail-state' into 'master'Anthony Sottile2020-01-132-10/+8
|\ | | | | | | | | config: Remove ConfigFileFinder 'parent' and 'tail' attributes See merge request pycqa/flake8!400
| * config: Remove ConfigFileFinder 'parent' and 'tail' attributesEric N. Vander Weele2020-01-122-7/+5
| | | | | | | | | | | | | | These attributes are only needed within the `.generate_possible_local_files()` method. Therefore, just obtain the current working directory at the beginning of the method and reduce the lifetime state of the `ConfigFileFinder` object.
| * tests: Ensure patched `os.getcwd()` is an absolute pathEric N. Vander Weele2020-01-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | `os.getcwd()` returns an absolute path; thus, the patched paths should be absolute as well. This is an incremental change towards removing the `ConfigFileFinder` attributes `.parent` and `.tail` to be localized to `.generate_possible_local_files()`. Without this, the tests fail when moving the patching because `os.path.abspath()` calls `os.getcwd()`, expecting `os.getcwd()` to be an absolute path.
* | Merge branch 'config-finder-isolated-cleanup' into 'master'Anthony Sottile2020-01-131-3/+0
|\ \ | |/ |/| | | | | application: Remove stale docstring param for `.find_plugins()` See merge request pycqa/flake8!399
| * application: Remove stale docstring param for `.find_plugins()`Eric N. Vander Weele2020-01-121-3/+0
| | | | | | | | | | The 'ignore_config_files' parameter was accidentally not removed in c918e72.
* | Merge branch 'config-finder-isolated' into 'master'Anthony Sottile2020-01-089-54/+60
|\ \ | |/ | | | | | | Determine config isolation from the ConfigFileFinder object See merge request pycqa/flake8!398
| * Remove unused 'isolated' parameterEric N. Vander Weele2020-01-078-48/+22
| | | | | | | | | | | | Now that `ConfigFileFinder.ignore_config_files` attribute is used everywhere and is constructed from the `--isolated` CLI option, the now unused `isolated` parameters can be safely removed.
| * config: Switch code paths to use 'ConfigFileFinder.ignore_config_files'Eric N. Vander Weele2020-01-074-3/+6
| | | | | | | | | | | | | | | | | | Now that the `ConfigFileFinder` has the `.ignore_config_files` attribute, switch the relevant code paths to utilize this public attribute. Tests have been updated to either construct `ConfigFileFinder` or mock the object appropriately.
| * config: Add 'ignore_config_files' parameter to ConfigFileFinderEric N. Vander Weele2020-01-073-3/+32
|/ | | | | | | | | The `--isolated` flag is passed into `MergedConfigParser.parse()` and the module-level function `config.get_local_plugins()`. Since both of these places utilize the `ConfigFileFinder` object and isolation pertains to how the `ConfigFileFinder` should behave with respect to isolation, this incremental change more directly associates the `ConfigFileFinder` and configuration file isolate.
* Merge branch 'config-read-varargs' into 'master'Anthony Sottile2020-01-073-9/+9
|\ | | | | | | | | config: Change ConfigFileFinder._read_config() to accept variadic args See merge request pycqa/flake8!397
| * config: Change ConfigFileFinder._read_config() to accept variadic argsEric N. Vander Weele2020-01-063-9/+9
|/ | | | | | | | | | | | | This simplifies `._read_config()` by removing a conditional branch in the situation where it is called with one file to process. Now the contract accepts any number of arguments of the same type. Where callers invoke `._read_config()` with a `Sequence`, the call site has been changed to unpack arguments (i.e., `*`). The tests in `test_merged_config_parser.py` needed to return a string for the user configuration path instead of an empty list since `ConfigFileFinder.user_config_file()` returns a string.
* Merge branch 'aggregator-config-isolated-fix' into 'master'Anthony Sottile2019-12-306-19/+74
|\ | | | | | | | | | | | | aggregator: Forward --config and --isolated options during aggregation Closes #605 See merge request pycqa/flake8!395
| * tests: Add integration tests for `--config` and `--isolated`Eric N. Vander Weele2019-12-291-0/+28
| | | | | | | | | | Prevent regressions by adding integration tests to ensure that these options are passed through to `aggregator.aggregate_options()`.
| * aggregator: Forward --config and --isolated options during aggregationEric N. Vander Weele2019-12-295-19/+46
|/ | | | | | | | | | | | | | This fixes a regression introduced in !346 to ensure that `--config` and `--isolated` are recognized in `aggregate_options()`. The regression manifested because `aggregate_options()` was relying on re-parsing `argv` to obtain the option values. However, !346 changed the preliminary parsing logic to only parse and "eat" what is necessary and forward along the options needed before all the configuration was loaded. This code path was overlooked because the tests in `test_aggregator()` were passing but the call from the `Application` object would never have these options in the remaining `argv` list to be passed long.
* Merge branch 'app-remove-make-config-finder' into 'master'Anthony Sottile2019-12-034-28/+13
|\ | | | | | | | | application: Inline creation of config.ConfigFileFinder See merge request pycqa/flake8!393
| * application: Inline creation of config.ConfigFileFinderEric N. Vander Weele2019-12-034-28/+13
|/ | | | | | Simplify the initialization code path by invoking `config.ConfigFileFinder` directly instead of the extra hop by calling the static class-level `Application.make_config_finder()` method.
* Merge branch 'fix/disable_noqa' into 'master'Anthony Sottile2019-12-033-1/+15
|\ | | | | | | | | | | | | `--disable-noqa` does not override `# flake8: noqa` Closes #590 See merge request pycqa/flake8!380
| * Remove redundant sample dataIsac Yoo2019-11-131-9/+2
| |
| * Fix codesByeonghoon Yoo2019-11-062-25/+34
| |
| * Fix lint errorByeonghoon Yoo2019-11-051-1/+2
| |
| * Add unit test for dd411e95Byeonghoon Yoo2019-11-052-13/+21
| |
| * Fix should_ignore_file() to handle disable-noqa configurationByeonghoon Yoo2019-11-051-1/+1
| |
| * Add disable_noqa attribute to FileProcessorByeonghoon Yoo2019-11-051-0/+3
| |
* | Merge branch 'typo' into 'master'Anthony Sottile2019-12-023-4/+4
|\ \ | | | | | | | | | | | | Fix typos See merge request pycqa/flake8!392
| * | Fix typosBrian Wignall2019-12-023-4/+4
|/ /
* | Merge branch 'fix/exit-zero' into 'master'Anthony Sottile2019-12-022-18/+7
|\ \ | | | | | | | | | | | | Fix --exit-zero when --diff is empty See merge request pycqa/flake8!391
| * | Fixes --exit-zero when empty --diffKinya TERASAKA2019-12-022-18/+7
| | | | | | | | | | | | fixes pycqa/flake8/merge_requests!137