diff options
| author | Eric N. Vander Weele <ericvw@gmail.com> | 2019-12-29 17:22:26 -0500 |
|---|---|---|
| committer | Eric N. Vander Weele <ericvw@gmail.com> | 2019-12-29 18:07:51 -0500 |
| commit | 7f9f70064c50bbb6024fafed4568e0693f5640b5 (patch) | |
| tree | a81485499d227115c26d3fadf3ed42302d67f413 /tests/unit | |
| parent | bb61b3df82a938f7cd1ca32daab4a31e4586b281 (diff) | |
| download | flake8-7f9f70064c50bbb6024fafed4568e0693f5640b5.tar.gz | |
aggregator: Forward --config and --isolated options during aggregation
This fixes a regression introduced in !346 to ensure that `--config` and
`--isolated` are recognized in `aggregate_options()`.
The regression manifested because `aggregate_options()` was relying on
re-parsing `argv` to obtain the option values. However, !346 changed
the preliminary parsing logic to only parse and "eat" what is necessary
and forward along the options needed before all the configuration was
loaded. This code path was overlooked because the tests in
`test_aggregator()` were passing but the call from the `Application`
object would never have these options in the remaining `argv` list to be
passed long.
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/test_legacy_api.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unit/test_legacy_api.py b/tests/unit/test_legacy_api.py index 8f6045e..d3b9eb5 100644 --- a/tests/unit/test_legacy_api.py +++ b/tests/unit/test_legacy_api.py @@ -34,7 +34,7 @@ def test_get_style_guide(): mockedapp.find_plugins.assert_called_once_with(config_finder, None, False) mockedapp.register_plugin_options.assert_called_once_with() mockedapp.parse_configuration_and_cli.assert_called_once_with( - config_finder, []) + config_finder, None, False, []) mockedapp.make_formatter.assert_called_once_with() mockedapp.make_guide.assert_called_once_with() mockedapp.make_file_checker_manager.assert_called_once_with() |