summaryrefslogtreecommitdiff
path: root/tests/subprocess_test.py
diff options
context:
space:
mode:
authorJakub Stasiak <jakub@stasiak.at>2015-02-11 23:03:52 +0100
committerJakub Stasiak <jakub@stasiak.at>2015-02-11 23:03:52 +0100
commitb4d385aec9c96cba1fdd062ac6802480f45ce244 (patch)
treed40a48b0ca544186217ea82d300b3bbe3c027718 /tests/subprocess_test.py
parent5ec3a3cba8029b577db1631f9db52f99954e4f54 (diff)
downloadeventlet-b4d385aec9c96cba1fdd062ac6802480f45ce244.tar.gz
Stop skipping a test unnecessarily
Diffstat (limited to 'tests/subprocess_test.py')
-rw-r--r--tests/subprocess_test.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/subprocess_test.py b/tests/subprocess_test.py
index 7fbcf0b..2760eac 100644
--- a/tests/subprocess_test.py
+++ b/tests/subprocess_test.py
@@ -1,7 +1,6 @@
import eventlet
from eventlet.green import subprocess
import eventlet.patcher
-from nose.plugins.skip import SkipTest
import sys
import time
original_subprocess = eventlet.patcher.original('subprocess')
@@ -29,14 +28,15 @@ def test_subprocess_wait():
def test_communicate_with_poll():
+ # This test was being skipped since git 25812fca8, I don't there's
+ # a need to do this. The original comment:
+ #
# https://github.com/eventlet/eventlet/pull/24
# `eventlet.green.subprocess.Popen.communicate()` was broken
# in Python 2.7 because the usage of the `select` module was moved from
# `_communicate` into two other methods `_communicate_with_select`
# and `_communicate_with_poll`. Link to 2.7's implementation:
# http://hg.python.org/cpython/file/2145593d108d/Lib/subprocess.py#l1255
- if getattr(original_subprocess.Popen, '_communicate_with_poll', None) is None:
- raise SkipTest('original subprocess.Popen does not have _communicate_with_poll')
p = subprocess.Popen(
[sys.executable, '-c', 'import time; time.sleep(0.5)'],