summaryrefslogtreecommitdiff
path: root/tests/test_query.py
diff options
context:
space:
mode:
authorBrian Wellington <bwelling@xbill.org>2020-06-08 11:01:44 -0700
committerBrian Wellington <bwelling@xbill.org>2020-06-08 11:01:44 -0700
commit9e59662498ceeda09d1ca3481bca15923de49ef8 (patch)
tree9441f9972dd55cf6f9259f8edda04f254d9414ba /tests/test_query.py
parent30c2562cb781a4977bb9f3ed0c2a3e573e74c1db (diff)
downloaddnspython-9e59662498ceeda09d1ca3481bca15923de49ef8.tar.gz
Fix leaked socket in testQueryTLSWithSocket.
Diffstat (limited to 'tests/test_query.py')
-rw-r--r--tests/test_query.py26
1 files changed, 13 insertions, 13 deletions
diff --git a/tests/test_query.py b/tests/test_query.py
index e031cfd..b9699d2 100644
--- a/tests/test_query.py
+++ b/tests/test_query.py
@@ -103,20 +103,20 @@ class QueryTests(unittest.TestCase):
@unittest.skipUnless(have_ssl, "No SSL support")
def testQueryTLSWithSocket(self):
- with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
- s.connect(('8.8.8.8', 853))
+ with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as base_s:
+ base_s.connect(('8.8.8.8', 853))
ctx = ssl.create_default_context()
- s = ctx.wrap_socket(s, server_hostname='dns.google')
- s.setblocking(0)
- qname = dns.name.from_text('dns.google.')
- q = dns.message.make_query(qname, dns.rdatatype.A)
- response = dns.query.tls(q, None, sock=s)
- rrs = response.get_rrset(response.answer, qname,
- dns.rdataclass.IN, dns.rdatatype.A)
- self.assertTrue(rrs is not None)
- seen = set([rdata.address for rdata in rrs])
- self.assertTrue('8.8.8.8' in seen)
- self.assertTrue('8.8.4.4' in seen)
+ with ctx.wrap_socket(base_s, server_hostname='dns.google') as s:
+ s.setblocking(0)
+ qname = dns.name.from_text('dns.google.')
+ q = dns.message.make_query(qname, dns.rdatatype.A)
+ response = dns.query.tls(q, None, sock=s)
+ rrs = response.get_rrset(response.answer, qname,
+ dns.rdataclass.IN, dns.rdatatype.A)
+ self.assertTrue(rrs is not None)
+ seen = set([rdata.address for rdata in rrs])
+ self.assertTrue('8.8.8.8' in seen)
+ self.assertTrue('8.8.4.4' in seen)
def testQueryUDPFallback(self):
qname = dns.name.from_text('.')