diff options
| author | Brian Wellington <bwelling@xbill.org> | 2020-03-18 11:26:55 -0700 |
|---|---|---|
| committer | Brian Wellington <bwelling@xbill.org> | 2020-03-18 11:26:55 -0700 |
| commit | e6798e58b4555740db4cfb43c8b9ce0d7d3416f1 (patch) | |
| tree | 7a2a5286ca49e0fe814eef39082a6d59b3d7289a /tests/test_bugs.py | |
| parent | fc74c9261dcd36fd1ec0f10d48c9c0fc56ce17ea (diff) | |
| download | dnspython-e6798e58b4555740db4cfb43c8b9ce0d7d3416f1.tar.gz | |
Improve assertion checking.
This replaces lots of self.assertTrue() assertions with more specific
assertions, such as replacing assertTrue(x == y) with assertEqual(x, y).
Diffstat (limited to 'tests/test_bugs.py')
| -rw-r--r-- | tests/test_bugs.py | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/tests/test_bugs.py b/tests/test_bugs.py index e7a3193..c4b0e3c 100644 --- a/tests/test_bugs.py +++ b/tests/test_bugs.py @@ -31,15 +31,15 @@ class BugsTestCase(unittest.TestCase): def test_float_LOC(self): rdata = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.LOC, u"30 30 0.000 N 100 30 0.000 W 10.00m 20m 2000m 20m") - self.assertTrue(rdata.float_latitude == 30.5) - self.assertTrue(rdata.float_longitude == -100.5) + self.assertEqual(rdata.float_latitude, 30.5) + self.assertEqual(rdata.float_longitude, -100.5) def test_SOA_BIND8_TTL(self): rdata1 = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.SOA, u"a b 100 1s 1m 1h 1d") rdata2 = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.SOA, u"a b 100 1 60 3600 86400") - self.assertTrue(rdata1 == rdata2) + self.assertEqual(rdata1, rdata2) def test_TTL_bounds_check(self): def bad(): @@ -49,14 +49,14 @@ class BugsTestCase(unittest.TestCase): def test_empty_NSEC3_window(self): rdata = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.NSEC3, u"1 0 100 ABCD SCBCQHKU35969L2A68P3AD59LHF30715") - self.assertTrue(rdata.windows == []) + self.assertEqual(rdata.windows, []) def test_zero_size_APL(self): rdata = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.APL, "") rdata2 = dns.rdata.from_wire(dns.rdataclass.IN, dns.rdatatype.APL, "", 0, 0) - self.assertTrue(rdata == rdata2) + self.assertEqual(rdata, rdata2) def test_CAA_from_wire(self): rdata = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.CAA, @@ -68,19 +68,19 @@ class BugsTestCase(unittest.TestCase): wire += b"trailing garbage" rdata2 = dns.rdata.from_wire(dns.rdataclass.IN, dns.rdatatype.CAA, wire, 0, rdlen) - self.assertTrue(rdata == rdata2) + self.assertEqual(rdata, rdata2) def test_trailing_zero_APL(self): in4 = "!1:127.0.0.0/1" rd4 = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.APL, in4) out4 = rd4.to_digestable(dns.name.from_text("test")) text4 = binascii.hexlify(out4).decode('ascii') - self.assertTrue(text4 == '000101817f') + self.assertEqual(text4, '000101817f') in6 = "!2:::1000/1" rd6 = dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.APL, in6) out6 = rd6.to_digestable(dns.name.from_text("test")) text6 = binascii.hexlify(out6).decode('ascii') - self.assertTrue(text6 == '0002018f000000000000000000000000000010') + self.assertEqual(text6, '0002018f000000000000000000000000000010') def test_TXT_conversions(self): t1 = dns.rdtypes.ANY.TXT.TXT(dns.rdataclass.IN, dns.rdatatype.TXT, @@ -91,9 +91,9 @@ class BugsTestCase(unittest.TestCase): 'foo') t4 = dns.rdtypes.ANY.TXT.TXT(dns.rdataclass.IN, dns.rdatatype.TXT, ['foo']) - self.assertTrue(t1 == t2) - self.assertTrue(t1 == t2) - self.assertTrue(t1 == t4) + self.assertEqual(t1, t2) + self.assertEqual(t1, t2) + self.assertEqual(t1, t4) if __name__ == '__main__': unittest.main() |