diff options
| author | Bob Halley <halley@dnspython.org> | 2020-08-18 06:28:21 -0700 |
|---|---|---|
| committer | Bob Halley <halley@dnspython.org> | 2020-08-18 06:28:21 -0700 |
| commit | 279dbec2722bd9836b1adf76db5136aeb346421e (patch) | |
| tree | 8ad06ec695b9e1034e2bc289bde1460fbec836c0 /dns/node.py | |
| parent | 352b15dd775370cd731dbab60b65cd50acf395b7 (diff) | |
| download | dnspython-279dbec2722bd9836b1adf76db5136aeb346421e.tar.gz | |
node replace_rdataset() should not permit rrsets
Diffstat (limited to 'dns/node.py')
| -rw-r--r-- | dns/node.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/dns/node.py b/dns/node.py index b7e21b5..b1baf27 100644 --- a/dns/node.py +++ b/dns/node.py @@ -180,6 +180,10 @@ class Node: if not isinstance(replacement, dns.rdataset.Rdataset): raise ValueError('replacement is not an rdataset') + if isinstance(replacement, dns.rrset.RRset): + # RRsets are not good replacements as the match() method + # is not compatible. + replacement = replacement.to_rdataset() self.delete_rdataset(replacement.rdclass, replacement.rdtype, replacement.covers) self.rdatasets.append(replacement) |