diff options
| author | Bob Halley <halley@dnspython.org> | 2020-06-13 10:57:46 -0700 |
|---|---|---|
| committer | Bob Halley <halley@dnspython.org> | 2020-06-13 10:57:46 -0700 |
| commit | dce23a614f2d11bd802c7f9aed8f3ab0e883f468 (patch) | |
| tree | 1c7ae84322313b3acb4a19a98445546d2270850c | |
| parent | d701908258b93a6434f4175cc0f8181cbd6cbb53 (diff) | |
| download | dnspython-dce23a614f2d11bd802c7f9aed8f3ab0e883f468.tar.gz | |
Add some comments about opportunities after 3.6 is not supported.
| -rw-r--r-- | dns/_asyncbackend.py | 3 | ||||
| -rw-r--r-- | dns/asyncquery.py | 3 | ||||
| -rw-r--r-- | tests/test_async.py | 1 |
3 files changed, 6 insertions, 1 deletions
diff --git a/dns/_asyncbackend.py b/dns/_asyncbackend.py index dc1330e..093713d 100644 --- a/dns/_asyncbackend.py +++ b/dns/_asyncbackend.py @@ -5,7 +5,8 @@ import socket import dns.inet -# This is a nullcontext for both sync and async +# This is a nullcontext for both sync and async. 3.7 has a nullcontext, +# but it is only for sync use. class NullContext: def __init__(self, enter_result=None): diff --git a/dns/asyncquery.py b/dns/asyncquery.py index 68d1a35..03e9fad 100644 --- a/dns/asyncquery.py +++ b/dns/asyncquery.py @@ -189,6 +189,7 @@ async def udp(q, where, timeout=None, port=53, source=None, source_port=0, wire = q.to_wire() (begin_time, expiration) = _compute_times(timeout) s = None + # After 3.6 is no longer supported, this can use an AsyncExitStack. try: if sock: s = sock @@ -391,6 +392,7 @@ async def tcp(q, where, timeout=None, port=53, source=None, source_port=0, wire = q.to_wire() (begin_time, expiration) = _compute_times(timeout) s = None + # After 3.6 is no longer supported, this can use an AsyncExitStack. try: if sock: # Verify that the socket is connected, as if it's not connected, @@ -468,6 +470,7 @@ async def tls(q, where, timeout=None, port=853, source=None, source_port=0, Returns a ``dns.message.Message``. """ + # After 3.6 is no longer supported, this can use an AsyncExitStack. (begin_time, expiration) = _compute_times(timeout) if not sock: if ssl_context is None: diff --git a/tests/test_async.py b/tests/test_async.py index ed75b9c..5c26309 100644 --- a/tests/test_async.py +++ b/tests/test_async.py @@ -57,6 +57,7 @@ class AsyncTests(unittest.TestCase): try: runner = asyncio.run except AttributeError: + # this is only needed for 3.6 def old_runner(awaitable): loop = asyncio.get_event_loop() return loop.run_until_complete(awaitable) |