diff options
author | shanghui <shangdahao@gmail.com> | 2017-11-08 16:32:49 +0800 |
---|---|---|
committer | Tim Graham <timograham@gmail.com> | 2017-11-08 09:39:12 -0500 |
commit | 359370a8b8ca0efe99b1d4630b291ec060b69225 (patch) | |
tree | dec84dbdd38f985a3a46e3d0c1e1f675e4f166cd /tests | |
parent | 3ae9c356c5d4b89caf8343aa3ffe0a66e713c9fd (diff) | |
download | django-359370a8b8ca0efe99b1d4630b291ec060b69225.tar.gz |
Fixed #28645 -- Reallowed AuthenticationForm to raise the inactive user error when using ModelBackend.
Regression in e0a3d937309a82b8beea8f41b17d8b6298da2a86.
Thanks Guilherme Junqueira for the report and Tim Graham for the review.
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auth_tests/test_forms.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/auth_tests/test_forms.py b/tests/auth_tests/test_forms.py index 1832f81c1c..5d2074e33a 100644 --- a/tests/auth_tests/test_forms.py +++ b/tests/auth_tests/test_forms.py @@ -262,9 +262,6 @@ class UserCreationFormTest(TestDataMixin, TestCase): ) -# To verify that the login form rejects inactive users, use an authentication -# backend that allows them. -@override_settings(AUTHENTICATION_BACKENDS=['django.contrib.auth.backends.AllowAllUsersModelBackend']) class AuthenticationFormTest(TestDataMixin, TestCase): def test_invalid_username(self): @@ -323,6 +320,8 @@ class AuthenticationFormTest(TestDataMixin, TestCase): self.assertFalse(form.is_valid()) self.assertEqual(form.non_field_errors(), [str(form.error_messages['inactive'])]) + # Use an authentication backend that allows inactive users. + @override_settings(AUTHENTICATION_BACKENDS=['django.contrib.auth.backends.AllowAllUsersModelBackend']) def test_custom_login_allowed_policy(self): # The user is inactive, but our custom form policy allows them to log in. data = { |