summaryrefslogtreecommitdiff
path: root/distutils2/compiler
diff options
context:
space:
mode:
author?ric Araujo <merwok@netwok.org>2011-02-10 00:51:42 +0100
committer?ric Araujo <merwok@netwok.org>2011-02-10 00:51:42 +0100
commit37d72aef1b216abd0840afd73c114bad25621a39 (patch)
treef6e479ad1ee4292eccd68aa9b7f120315a143457 /distutils2/compiler
parentb1bd0f37c556fd24b8cb45cf9d8989a61224144f (diff)
downloaddisutils2-37d72aef1b216abd0840afd73c114bad25621a39.tar.gz
Use lazy form in logging calls, again.
Logging calls have the signature (msg, *args, **kwargs) so that the %-formatting can be delayed until it is needed. Logger objects also have an isEnabledFor method that can be used to isolate expensive code. Next steps: use only one of d2.logger methods or logging module functions; use a proper handler in our test machinery instead of monkey-patching; remove cmd.warn and cmd.announce and use logging instead. TODOs have been added in the modules and on the wiki.
Diffstat (limited to 'distutils2/compiler')
-rw-r--r--distutils2/compiler/msvc9compiler.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/distutils2/compiler/msvc9compiler.py b/distutils2/compiler/msvc9compiler.py
index 25e832c..11a17d4 100644
--- a/distutils2/compiler/msvc9compiler.py
+++ b/distutils2/compiler/msvc9compiler.py
@@ -226,10 +226,10 @@ def find_vcvarsall(version):
productdir = os.path.join(toolsdir, os.pardir, os.pardir, "VC")
productdir = os.path.abspath(productdir)
if not os.path.isdir(productdir):
- logger.debug("%s is not a valid directory" % productdir)
+ logger.debug("%s is not a valid directory", productdir)
return None
else:
- logger.debug("Env var %s is not set or invalid" % toolskey)
+ logger.debug("Env var %s is not set or invalid", toolskey)
if not productdir:
logger.debug("No productdir found")
return None