diff options
| author | Andy Grover <agrover@redhat.com> | 2014-11-19 17:56:42 -0800 |
|---|---|---|
| committer | Andy Grover <agrover@redhat.com> | 2014-11-19 17:56:42 -0800 |
| commit | c5e3164bd437d4df8e31c0f771ab46d836d04617 (patch) | |
| tree | e8ec4903453471a5d752b12ab61a3affaeff71da | |
| parent | 39624bf2baca527a14850940b0b9c061f76e5fd7 (diff) | |
| download | configshell-fb-c5e3164bd437d4df8e31c0f771ab46d836d04617.tar.gz | |
Don't reuse "parameter" local variable
Later on in the function, we assume "parameter" is still the dict that
was passed in.
Reported-by: Fabian Deutsch <fdeutsch@redhat.com>
Signed-off-by: Andy Grover <agrover@redhat.com>
| -rw-r--r-- | configshell/node.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/configshell/node.py b/configshell/node.py index a773cb7..ee1d788 100644 --- a/configshell/node.py +++ b/configshell/node.py @@ -495,10 +495,10 @@ class ConfigNode(object): for p_name in self.list_group_params(group, writable=True): p_def = self.get_group_param(group, p_name) type_method = self.get_type_method(p_def['type']) - parameter = "%s=I{%s}" % (p_def['name'], p_def['type']) - underline2 = ''.ljust(len(parameter), '-') + p_name = "%s=I{%s}" % (p_def['name'], p_def['type']) + underline2 = ''.ljust(len(p_name), '-') parameters += '%s\n%s\n%s\n\n' \ - % (parameter, underline2, p_def['description']) + % (p_name, underline2, p_def['description']) self.shell.con.epy_write('''%s\n%s\n%s\n''' % (section, underline1, parameters)) |