| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
The previous fix was not entirely complete.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
|
| |
Apparently "WIBBLE" is just a test, and maybe the test was "How
long does it take until somebody notices a strange row in configure.ac
and tries to remove it", if so, the test result is "a little over
three years". :-)
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
| |
We will just ignore the memblock if this happens. We already have
a check for this in the client library, so this one is just for
security reasons.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
| |
If somebody tries to push a non-frame-aligned memblock onto the
memblockq, then we should fail the write. Otherwise the daemon will
crash, see https://bugs.freedesktop.org/show_bug.cgi?id=77595
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Since we don't allow lengths that are not frame aligned,
it does not make sense to allow indices that are not frame aligned
either.
Also, allowing such a thing to be added causes the daemon to crash
later instead (see https://bugs.freedesktop.org/show_bug.cgi?id=77595 ).
Also drop _se from assert (there is no side effect).
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
| |
This fixes a bug in latency configuration. The wrong type in the cast
caused UINT64_MAX being not treated as special, so the configured
latency was set to UINT64_MAX usecs, which of course is absurdly huge
latency.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should not have any effect on behaviour. The goal is to align
with the pattern that I think we should follow:
Object initialization:
- put() is the place to create references from other objects to the
newly created object. In this case, adding the transport to
discovery->transports was moved from new() to put, and adding the
transport to device->transports was moved from set_state() to
put().
Object destruction:
- unlink() undoes put() and removes all references from other objects
to the object being unlinked. In this case setting the
device->transports pointer to NULL was moved from set_state() to
unlink(), and setting the discovery->transports pointer to NULL was
moved from free() to unlink().
- free() undoes new(), but also calls unlink() so that object owners
don't need to remember to call unlink() before free().
|
| |
|
|
| |
Signed-off-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
This fixes getting the binary name in the Hurd, or any other port using
the GNU C library, but only in the case where the library is directly
linked to. Opening with dlopen will not work.
Change in v3: reorder header includes and definitions
Change in v2: use a weak reference to main, so that we
don't crash when main cannot be found.
|
| |
|
|
|
|
|
|
| |
This test broke when PA_MAX_INPUTS_PER_SINK was increased from 32 to 256.
Because we currently don't have time to figure out why, let's just set
NSTREAMS to 20 in the meantime.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
| |
The default maximum latency is 10 seconds, which is not good,
especially since the tunnel sink doesn't support rewinding. Due to the
lack of rewinding, e.g. volume changes take a long time with large
latencies.
|
| |
|
|
|
|
|
|
|
|
|
| |
It seems at some point the code migrated to use the entry_write calls,
but fill_db is still using the old syntax, causing the entry to be
invalid.
The crash happens when clean_up_db gets called, which then calls
entry_read, causing the crash.
Signed-off-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
|
| |
|
|
|
| |
This fixes userdata.only_from_unavailable being uninitialized in case
the user doesn't give the value in modargs.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
If the keyboard is unplugged, it looks like the kernel is reporting
back -ENODEV when trying to close the fd. This is probably a kernel
error, but still, it's better to complain than to crash.
Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=80867
Reported-by: Stelios Bounanos
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
| |
Since we already have pa_set_env(), it's nice to also have a
corresponding function for unsetting environment variables.
|
| |
|
|
|
|
|
|
|
| |
It is possible that the chosen active_port doesn't equal
new_data->active_port, using p->name is more accurate.
Please refer to sink_new_hook_callback()
Signed-off-by: Hui Wang <hui.wang@canonical.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now a2dp and hsp sinks and sources will have different names which means that
applications and other modules can use sink/source to distinguish selected
profile.
Module module-device-restore uses sink/source name and port name as identifier,
so if different profiles have different names module-device-restore can store
volume settings for each profile.
So with this patch it is possible to configure different volume settings for
a2dp and hsp profiles.
This patch does not change port names so gnome applications will be happy.
Note that similar patch is needed also for bluez5, but I'm not using bluez5
so I cannot write or test it.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On a machine without fixed connecting audio devices like internal
microphone or internal speaker, and when there is no external audio
devices plugging in, the default source/sink is alsa_input/alsa_output
and there is no input devices/output devices listed in the gnome
sound-setting.
Under this situation, if we connect a bluetooth headset, the gnome
sound-setting will list bluez input/output devices, but they are not
active devices by default. This looks very weird that sound-setting
lists only one input device and one output device, but they are not
active. To change this situation, we add an argument, the policy is
if a new source/sink is connected and current default source/sink's
active_port is AVAILABLE_NO, we let the new added one switch to
default one.
BugLink: http://bugs.launchpad.net/bugs/1369476
Signed-off-by: Hui Wang <hui.wang@canonical.com>
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling the callback while setting it up can make things
complicated for clients, as the callback can do arbitrarily
things.
In this case, a protocol error caused the srbchannel to be
owned by both the pstream and the native connection.
Now the read callback is deferred, making sure the callback
is called from a cleaner context where errors are handled
appropriately.
Reported-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
| |
Hard-coding constants on several places is bad coding practice.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
| |
Lennart probably had a card with a specific name. It is not a
common name anymore.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
| |
As a third parameter, add the number of samples to read/write in
every iteration. This will help slow CPUs.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
| |
This allow 'off' profile to be choosen when no other profile is available
which is considered better since it requires less resources than other
profiles.
|
| |
|
|
|
| |
In case the socket HUP the transport state should be set to idle which
will indicate the profile is no longer available.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Now that we have switched to using the mixer handle only,
there is no use for sending hctl handles around.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
| |
Use the new mixer API to get callbacks, instead of using the hctl
API. Using the hctl API caused a memory leak, because alsa-lib itself
used the hctl callbacks, which we were previously overriding.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| |
|
|
|
|
|
|
|
|
| |
Instead of using the hctl interface, we can find controls belonging
to other iface types than "mixer". We do this by introducing a new
mixer class "SND_MIXER_ELEM_PULSEAUDIO" and create snd_mixer_elem's
for all PCM and CARD iface types (as Jacks are of the CARD type and
ELD controls are of the PCM type).
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Register as a HandsfreeAudioAgent with oFono during backend
initialization and unregiter during backend finalization. This commit
also adds a check when receiving method calls or signals to make sure
the sender matches with the D-Bus service we're registered with.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
code has been moved to cpu-mix-test
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
| |
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
| |
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
| |
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
| |
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
|
|
| |
Make run_remap_test() support up to 8 input and output channels.
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
| |
|
|
|
|
| |
Cleanup and add function to setup remap struct
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
|
