summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* pstream: Support memfd blocks transportAhmed S. Darwish2016-04-0217-75/+454
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we have the necessary infrastructure to memexport and mempimport a memfd memblock, extend that support higher up in the chain with pstreams. A PA endpoint can now _transparently_ send a memfd memblock to the other end by simply calling pa_pstream_send_memblock() – provided the block's memfd pool was earlier registered with the pstream. If the pipe does not support memfd transfers, we fall back to sending the block's full data instead of just its reference. ** Further details: A single pstream connection usually transfers blocks from multiple pools including the server's srbchannel mempool, the client's audio data mempool, and the server's global core mempool. If these mempools are memfd-backed, we now require registering them with the pstream before sending any blocks they cover. This is done to minimize fd passing overhead and avoid fd leaks. Moreover, to support all these pools without hard-coding their number or nature in the Pulse communication protocol itself, a new REGISTER_MEMFD_SHMID command is introduced. That command can be sent _anytime_ during the pstream's lifetime and is used for creating on demand SHM ID to memfd mappings. Suggested-by: David Henningsson <david.henningsson@canonical.com> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* pulsecore: Specially mark global mempoolsAhmed S. Darwish2016-04-0215-19/+124
| | | | | | | | | | | | | | | | | | | | | Color global mempools with a special mark. This special marking is needed for handling memfd-backed pools. To avoid fd leaks, memfd pools are registered with the connection pstream to create an ID<->memfd mapping on both PA endpoints. Such memory regions are then always referenced by their IDs and never by their fds, and so their fds can be safely closed later. Unfortunately this scheme cannot work with global pools since the registration ID<->memfd mechanism needs to happen for each newly connected client, and thus the need for a more special handling. That is, for the pool's fd to be always open :-( Almost all mempools are now created on a per-client basis. The only exception is the pa_core's mempool which is still shared between all clients of the system. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* memimport: Support memfd blocksAhmed S. Darwish2016-04-026-23/+113
| | | | | | | | | | | | | | | | To transfer memfd-backed blocks without passing their fd every time, thus minimizing overhead and avoiding fd leaks, a command is sent with the memfd fd as ancil data very early on. This command has an ID that uniquely identifies the memfd region. Further memfd block references are then exclusively done using this ID. This commit implements the details of such 'permanent' mappings on the receiving end, using memimport segments. Suggested-by: David Henningsson <david.henningsson@canonical.com> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* pulsecore: Introduce memfd supportAhmed S. Darwish2016-04-025-65/+230
| | | | | | | | | | | | | | | | | | Memfd is a simple memory sharing mechanism, added by the systemd/kdbus developers, to share pages between processes in an anonymous, no global registry needed, no mount-point required, relatively secure, manner. This patch introduces the necessary building blocks for using memfd shared memory transfers in PulseAudio. Memfd support shall also help us in laying out the necessary (but not yet sufficient) groundwork for application sandboxing, protecting PA from its clients, and protecting clients data from each other. We plan to exclusively use memfds, instead of POSIX SHM, on the way forward. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* SHM: Refactor private allocationsAhmed S. Darwish2016-04-021-73/+87
| | | | | | | | | | | pa_shm_create_rw() is responsible for creating two types of memory: POSIX shared memory and regular malloc()-ed ones. A third memory type, memfds, will be added later. Thus to add this extra shared memory type in a sane manner, refactor private memory allocations into their own static methods. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* pulsecore: Transform pa_mempool_new() into a factory methodAhmed S. Darwish2016-04-0218-37/+97
| | | | | | | | | | Soon we're going to have three types of memory pools: POSIX shm_open() pools, memfd memfd_create() ones, and privately malloc()-ed pools. Thus introduce annotations for the memory types supported and change pa_mempool_new() into a factory method based on required memory. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* srbchannel: Introduce per-client SHM filesAhmed S. Darwish2016-04-023-17/+27
| | | | | | | | | | | | The PA daemon currently uses a single SHM file for all clients sending and receiving commands over the low-latency srbchannel mechanism. To avoid leaks between clients in that case, and to provide the necessary ground work later for sandboxing and memfds, create the srbchannel SHM files on a per-client basis. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* pulsecore: Reference count mempoolsAhmed S. Darwish2016-04-0217-20/+84
| | | | | | | | | | | | | | | | | | | In future commits, server-wide SHMs will be replaced with per-client ones that will be dynamically created and freed according to clients connections open and close. Meanwhile, current PA design does not guarantee that the per-client mempool blocks are referenced only by client-specific objects. Thus reference count the pools and let each memblock inside the pool itself, or just attached to it, increment the pool's refcount upon allocation. This way, per-client mempools will only be freed when no further component in the system holds any references to its blocks. DiscussionLink: https://goo.gl/qesVMV Suggested-by: Tanu Kaskinen <tanuk@iki.fi> Suggested-by: David Henningsson <david.henningsson@canonical.com> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* pulsecore: Cache daemon shm size inside pa_coreAhmed S. Darwish2016-04-022-0/+6
| | | | | | | | | | | | The daemon `shm-size-bytes' configuration value was read, and then directly used, for creating the initial server-wide SHM files. This is fine for now, but soon, such server-wide SHMs will be replaced with per-client SHM files that will be dynamically created and deleted according to clients open and close. Thus, appropriately cache this configuration value. Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* log: journal: Prevent duplicate values for CODE_* fieldsAhmed S. Darwish2016-03-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | sd_journal_send() implicitly add fields for the source file, function name and code line from where it's invoked. As code location fields CODE_FILE, CODE_LINE and CODE_FUNC are handled by PA's log module, we do not want the automatic values supplied by the sd_journal API. Without suppressing these, both the actual log event source and the call to sd_journal_send() will be logged: $ journalctl -b -f -o json-pretty [...] CODE_FILE : [ pulsecore/log.c, pulsecore/module.c ], CODE_LINE : [ 505, 181 ], MESSAGE : Failed to load module module-gconf CODE_FUNC : [ pa_log_levelv_meta, pa_module_load ], [...] (Commit log adapted from abrt libreport commit d1eaae97f0287f) Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
* stream-interaction: interact if a stream starts corkedGeorg Chini2016-03-211-13/+19
| | | | | | This patch deals with the case that applications start new streams corked. In case of module-role-cork it will only mute the stream because corking is removed later by the application.
* role-ducking: use the common code in stream-interaction.cGeorg Chini2016-03-212-275/+5
|
* stream-interaction: add ducking functionalityGeorg Chini2016-03-211-13/+43
|
* stream-interaction: Bugfix for improper uncorking behavior with global=1Georg Chini2016-03-181-1/+17
| | | | | | | This patch is based on a recent patch for module-role-ducking from Sangchul Lee which fixes incorrect behavior when global is set to 1. Original commit can be found here: https://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=d049c2941e6aef5ff33bcd0b4adece12289302b7
* filter-apply: fix typo "what" -> "want"Tanu Kaskinen2016-03-171-1/+1
|
* role-cork: more cosmetic changes, changed debug outputGeorg Chini2016-03-161-23/+21
| | | | | Change names of shall_interact() and is_trigger_stream() because the names look like the functions return a boolean. Simpler debugging output.
* role-cork: prepare merge with role-ducking: replace "cork" with "interact" ↵Georg Chini2016-03-153-45/+45
| | | | | | where appropriate Again, interact includes cork and duck.
* role-cork: prepare merge with role-ducking: move most code to ↵Georg Chini2016-03-144-337/+401
| | | | | | stream-interaction.c Filename suggested by Tanu, as it includes both, cork and duck.
* role-cork: remove corking on module exitGeorg Chini2016-03-131-12/+46
| | | | | While module-role-ducking removes the attenuation when the module exits, module-role-cork does not remove the corking. Added a function for that.
* role-cork: allow cork of all non-trigger streams using cork_roles=any_roleGeorg Chini2016-03-121-2/+4
| | | | | There might be situations where you want to cork all streams that are not trigger streams. Use cork_roles=any_role to implement this.
* role-cork: React to mute/cork of trigger streams and to proplist changesGeorg Chini2016-03-111-11/+62
| | | | | | When a trigger stream changes mute or cork state, the cork streams should react to this. The same applies if a stream changes its role to or from the trigger role.
* role-cork: Don't ignore streams without media.roleGeorg Chini2016-03-101-6/+2
| | | | | | When corking do not ignore streams without media.role. Instead treat them as if media.role="no_role", so that you can specify "no_role" as trigger or cork role.
* resampler-test: remove translationsTanu Kaskinen2016-03-101-21/+21
| | | | | | Translators shouldn't be burdened with translating strings in tests. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=94435
* Updated Hungarian translationGabor Kelemen2016-03-091-1548/+2046
|
* card-restore: save the database when shutting downTanu Kaskinen2016-03-081-1/+3
| | | | | | | | If u->save_time_event is non-NULL when the module is being unloaded, it means that there are some changes to the database that haven't yet been flushed to the disk. Acked-by: David Henningsson <david.henningsson@canonical.com>
* alsa-mixer: refactor element_probe and fix >2 channel bugDavid Henningsson2016-03-081-230/+206
| | | | | | | | | | | | | By refactoring volume probing into its own function, we can reduce indentation a lot. Also, if an error occurs during the volume probe, that volume element is now always skipped (instead of taking down the entire path with it). Also, a bug for elements with more than two channels is fixed, as previously, the volume parsing code was continuing, potentially referencing somewhere outside the array (which has max two channels). Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* switch-on-port-available: Switch from HDMI to analog; but not the other way ↵David Henningsson2016-02-261-3/+3
| | | | | | | | | | | | | | | around If you have headphones plugged in and plug in HDMI; you want sound to stay on headphones. If you have HDMI plugged in and you plug in headphones; you want sound to switch to headphones. Hence we need to take priority into account as well when determining whether to switch to a new profile or not. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=93903 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* echo-cancel: Convert AGC API to deal with pa_volume_tArun Raghavan2016-02-253-25/+23
| | | | | | | | | | | It is expected that the underlying AGC mechanism will likely provide a single volume for the source rather than a per-channel volume. Dealing with per-channel volumes just adds complexity with regards to the actual volume setting (depending on whether volume sharing is enabled or not, we would set the volume on the source output of the virtual source, and their sample specs may be different). Using a single volume allows us to sidestep this problem entirely.
* echo-cancel: Add beamforming support in the webrtc cancellerArun Raghavan2016-02-251-3/+148
|
* echo-cancel: Remove pa_ prefix on private functionsArun Raghavan2016-02-252-8/+8
|
* echo-cancel: Update a copyright noticeArun Raghavan2016-02-251-1/+2
|
* echo-cancel: Use webrtc's deinterleaved APIArun Raghavan2016-02-253-25/+30
| | | | | | This is required to have unequal channel counts on capture in and out streams, which is needed for beamforming to work. The deinterleaved API only works with floating point samples.
* echo-cancel: webrtc canceller supports different in/out channel countsArun Raghavan2016-02-252-7/+9
| | | | Needed for upcoming beamforming code.
* echo-cancel: Improve webrtc canceller error handling a bitArun Raghavan2016-02-251-4/+8
|
* echo-cancel: Fix webrtc canceller when rec channels != play channelsArun Raghavan2016-02-252-14/+14
| | | | | | The calculations around how many samples were sent to the canceller engine was not updated when we started supporting different channel counts for playback and capture.
* echo-cancel: Make webrtc AGC start volume a modargArun Raghavan2016-02-251-3/+16
| | | | Allows for tuning based on the target hardware.
* echo-cancel: Use anonymous unions for echo canceller paramsArun Raghavan2016-02-255-70/+71
| | | | Makes this part of the code just a little less verbose.
* build-sys: Move to compiling with C11 supportArun Raghavan2016-02-2514-20/+98
| | | | | | | | This is needed for building with anonymous unions. A bunch of calls to fail() that used to mysteriously work need fixing -- fail() is a macro that takes a printf-style message as an argument. Not passing this somehow worked with the previous compiler flags, but breaks with -std=c11.
* echo-cancel: Add a modarg toggle for VAD in the webrtc cancellerArun Raghavan2016-02-251-2/+11
|
* echo-cancel: Allow enabling of the webrtc experimental AGC mechanismArun Raghavan2016-02-251-1/+11
|
* echo-cancel: Start capture at a sane volume if we're doing webrtc AGCArun Raghavan2016-02-252-1/+14
| | | | | This is required to make sure the capture output has sufficient energy for the AGC to do its job.
* echo-cancel: Deal with volume limit breakage in webrtc AGCArun Raghavan2016-02-251-4/+21
| | | | | | The AGC code no longer seems to honour the analog volume limits we set, and internally uses 0-255 as the volume range. So we switch to use that (keeping the old API usage as is in case this gets fixed upstream).
* echo-cancel: Allow enabling tracing output from the webrtc cancellerArun Raghavan2016-02-252-1/+41
|
* echo-cancel: Mark private function as staticArun Raghavan2016-02-251-3/+3
|
* echo-cancel: Add a modarg to use sink/source master format and specArun Raghavan2016-02-251-7/+26
| | | | | | | | | | | | This allows us to inherit the sample spec parameters from the sink and source master (rather than forcing 32 kHz / mono). It is still possible to override some of the parameters for the source side with modargs. My original testing showed that these parameters provided a decent perf/quality trade-off on lower end hardware (which I no longer have access to). I figure it makes sense to continue with that for now, and in the future this can be relaxed (use_master_format=yes could be the default, and resource-constrained systems can disable it).
* echo-cancel: Express restrictions correctly on webrtc AEC stream configArun Raghavan2016-02-251-8/+27
| | | | | | | | | | In the refactoring, I'm expressing the constraints in what I see to be a more natural way -- rec_ss expresses what we're feeding the canceller, so it makes sense to apply the constraints on what the canceller accepts there. This then propagates to the output spec. This also exposes the range of sample rates that the library actually supports (8, 16, 32 and 48 kHz).
* echo-cancel: Canceller may use different spec for playback and captureArun Raghavan2016-02-241-1/+3
| | | | | | | | | The original intention was to configure low enough parameters to keep CPU consumption down. Prior to this change, we assumed that the EC backend would override the sink parameters based on the source parameters to achieve this goal, and with this change we remove that assumption by forcing the default parameters for the sink to be low enough.
* echo-cancel: Add some bits for webrtc intelligibility enhancerTanu Kaskinen2016-02-241-2/+18
| | | | | | | | | | It's not possible to enable the intelligibility enhancer at the moment, because the feature would require modifying the audio that we play to speakers, which we don't do currently. All audio processing is done at the source side, and it's not easy to change that. This patch is based on Arun Raghavan's code, I just reordered things a bit and reworded the FIXME comment.
* echo-cancel: Allow enabling the extended filter in webrtc AECArun Raghavan2016-02-241-2/+14
| | | | | | | | | This creates a longer filter that is more complex and less sensitive to incorrect delay reporting from the hardware. There is also a delay-agnostic mode that can eventually be enabled if required. In some very quick testing, not enabling this seems to provide better results during double-talk.
* echo-cancel: Update webrtc-audio-processing usage to new APIArun Raghavan2016-02-245-27/+630
| | | | | The code now needs C++11 support to compile with the updated webrtc-audio-processing library.
View Lorry Controller Status