summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* configure: Bump sonamesDavid Henningsson2014-11-211-1/+1
| | | | Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* bluetooth: set gain correctlyWim Taymans2014-11-211-4/+4
| | | | | | | | Send the right command to set the speaker and microphone gain. Note that setting the volume on the Headset should use the unsolicited result code. Receiving the volume from the Headset uses the AT command.
* raop: Fix a memory leakTanu Kaskinen2014-11-201-2/+7
| | | | a.path_or_host wasn't freed after calling pa_parse_address().
* alsa-mixer: Use pa_assert_not_reached()Peter Meerwald2014-11-171-2/+1
| | | | | | | | | | get rid of the following warning when compiling with NDEBUG: modules/alsa/alsa-mixer.c: In function 'element_is_subset': modules/alsa/alsa-mixer.c:3125:18: warning: 'a_limit' may be used uninitialized in this function [-Wmaybe-uninitialized] long a_limit; Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* tests: Use pa_assert_se() to get rid of an used variable warningPeter Meerwald2014-11-171-6/+4
| | | | | | when compiled with NDEBUG Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* core: Annotate variables only used within assert()s to be PA_UNUSEDPeter Meerwald2014-11-177-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | supresses a warning when compiling with NDEBUG: pulsecore/aupdate.c: In function 'pa_aupdate_read_end': pulsecore/aupdate.c:82:14: warning: variable 'n' set but not used [-Wunused-but-set-variable] unsigned n; pulsecore/sink-input.c: In function 'pa_sink_input_unlink': pulsecore/sink-input.c:648:27: warning: variable 'p' set but not used [-Wunused-but-set-variable] pa_source_output *o, *p = NULL; pulsecore/sink-input.c: In function 'find_filter_sink_input': pulsecore/sink-input.c:1523:14: warning: unused variable 'i' [-Wunused-variable] unsigned i = 0; pulsecore/sink-input.c: In function 'pa_sink_input_start_move': pulsecore/sink-input.c:1569:27: warning: variable 'p' set but not used [-Wunused-but-set-variable] pa_source_output *o, *p = NULL; CC pulsecore/libpulsecore_5.0_la-sink.lo pulsecore/sink.c: In function 'pa_sink_unlink': pulsecore/sink.c:673:24: warning: variable 'j' set but not used [-Wunused-but-set-variable] pa_sink_input *i, *j = NULL; pulsecore/source-output.c: In function 'find_filter_source_output': pulsecore/source-output.c:1179:9: warning: unused variable 'i' [-Wunused-variable] int i = 0; CC pulsecore/libpulsecore_5.0_la-source.lo pulsecore/source.c: In function 'pa_source_unlink': pulsecore/source.c:616:27: warning: variable 'j' set but not used [-Wunused-but-set-variable] pa_source_output *o, *j = NULL; Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* macro: Add macro PA_UNUSEDPeter Meerwald2014-11-171-0/+6
| | | | | | | | | | | | | | the macro PA_UNUSED may be used to suppress a warning when a variable is not used, or assigned and never used; this typically happens when the only use of the variable is within an assert() that can be optimized away (i.e. with NDEBUG set) has an effect with GCC only v2: (thanks to Alexander Patrakov) * fix patch subject/description Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* macro: Abort() when pa_assert_not_reached() even for NDEBUGPeter Meerwald2014-11-171-1/+1
| | | | | | | | | fixes many warnings when compiling with NDEBUG, such as CC pulse/libpulse_la-channelmap.lo pulse/channelmap.c: In function 'pa_channel_map_init_auto': pulse/channelmap.c:397:1: warning: control reaches end of non-void function [-Wreturn-type] Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* build-sys: Deprecate libsamplerate supportPeter Meerwald2014-11-172-1/+7
| | | | | | | | | | | | | | output DEPRECATED warnings for libsamplerate in configure and PA daemon's log libsamplerate offers no particular advantage over the speex resampler and is distributed under GPL; support for it will be removed in one of the next releases v2: (thanks Arun Raghavan) * log a warning (instead of info) Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* alsa-util: Finish description of pa_alsa_set_hw_params()Peter Meerwald2014-11-171-2/+3
| | | | | | ... which stops mid-sentence and logging cleanup Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* dbus-iface: Initialize "new_active" variable to NULLDavid Henningsson2014-11-171-1/+1
| | | | | | | | Fixes warning: 'new_active' may be used uninitialized in this function, and could potentially cause erronous behaviour in case an invalid port name was specified. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* Alsa: Correct port availability with multiple jacksSjoerd Simons2014-11-171-7/+18
| | | | | | | | | | | | In case there are two independent jacks for one port (e.g. Dock Headphone Jack and Headphone Jack), the availability ends up being incorrect if the first one was _NO (not plugged) and the second gets _YES (plugged). Also pulse complains about the state being inconsistent which isn't true. Fix this by preferring more precise states (yes/no) over unknown and yes over others. However in case a plugged jack makes the port unavailable let that overrule everything else.
* dbus: Fix the ActivePort property handlerTanu Kaskinen2014-11-141-1/+10
| | | | | | | | The old code tried to look up the port object by using an object path, but the ports hashmap uses port names as keys, so the method failed always. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=85369
* shell-completion: zsh: Fix the set-card-profile descriptionTanu Kaskinen2014-11-141-1/+1
|
* shell-completion: zsh: Fix set-default-sink/source completionTanu Kaskinen2014-11-141-0/+2
| | | | | The _devices() function didn't recognize the set-default-* commands, and as a result it didn't generate any completions.
* bluetooth: Select headset backend through module argumentDavid Henningsson2014-11-144-6/+55
| | | | | | | | | | | This patch adds a module argument "headset=ofono|native|auto" to module-bluetooth-discover and module-bluez5-discover. To make Arun's happy, the default is 'native' if compiled in, otherwise 'ofono'. 'Auto' will try to autoswitch depending on whether ofono is running or not. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* bluez 5: remove null headset backendDavid Henningsson2014-11-141-37/+0
| | | | | | There is no need to have a "null" backend anymore. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* bluez 5: Fix a debug messageDavid Henningsson2014-11-141-1/+1
| | | | Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* bluez 5: Load the native headset backend if the oFono one is unavailableDavid Henningsson2014-11-143-11/+28
| | | | | | | | | | | This implements some autodetect if both headset backends are compiled in: First we try to contact the oFono service, if that's not working, then we start the native backend instead. Likewise if the oFono service is going offline/online, we load/unload the native backend accordingly. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* bluez 5: Build both headset backends, if availableDavid Henningsson2014-11-146-29/+69
| | | | | | | Enable both ofono and native backends to be built into the same libbluez5-util. Never build the null backend. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* resampler: Fix sample_format_more_precise() for the case of comparing ↵Andrey Semashev2014-11-121-1/+1
| | | | | | against PA_SAMPLE_S32BE Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* .gitignore: Add pulseaudio.serviceTanu Kaskinen2014-11-121-0/+1
|
* build-sys: Fix a variable value checkTanu Kaskinen2014-11-121-1/+1
|
* build-sys: Fix daemon linking when building with systemd-daemon supportMauro Guerrera2014-11-101-0/+5
| | | | | | | | | | | Seems that after commit 467b4b9be systemd usage has been added into src/daemon/main.c but there is no link for the corresponding library in the final pulseaudio binary. This might be missed in some build systemd due to overlinking, but it's correct to add this in here explicitly Signed-off-by: Colin Guthrie <colin@mageia.org>
* rtpoll: Fixup pa_rtpoll_runDavid Henningsson2014-11-106-6/+6
| | | | | | | | | Commit fa092af59cf64902a5caa99 removed an argument to pa_rtpoll_run, but forgot to remove that argument for all callers to pa_rtpoll_run. This commit removes the remaining ones. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* rtpoll: Drop extra wait_op argument to pa_rtpoll_run()Peter Meerwald2014-11-0917-24/+23
| | | | | | is always true, not used Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* rtpoll: Fix condition for DEBUG_TIMING outputPeter Meerwald2014-11-091-2/+4
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* mix: Length over all chunk has already been computed by the callerPeter Meerwald2014-11-091-2/+1
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* mix: pa_mix() is always called with more than one steamPeter Meerwald2014-11-091-1/+2
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* iochannel: Remove unnecessary zero-initializationPeter Meerwald2014-11-091-2/+0
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* alsa: Precompute maximum frames per blockPeter Meerwald2014-11-092-4/+8
| | | | | | | | | frames_per_block is the mempool's maximum block size in frames v2 (thanks David Henningson) * rename max_frames to frames_per_block Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* core: Replace assert()s with pa_assert()sPeter Meerwald2014-11-097-12/+11
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* log: CleanupPeter Meerwald2014-11-091-1/+1
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* mix: Make use of pa_cvolume_is_norm/muted() macrosPeter Meerwald2014-11-091-2/+2
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* alsa-mixer: Add support for "Headphone+LO" and "Speaker+LO"David Henningsson2014-11-066-0/+64
| | | | | | | These two control names are currently being added to the HDA driver, so let's support them in PulseAudio as well. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* pstream: Duplicate assignment, write.data is always NULLPeter Meerwald2014-11-061-1/+0
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* asyncmsgq: Drop weird assertPeter Meerwald2014-11-061-2/+0
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* resampler: Drop pointless remix variablePeter Meerwald2014-11-061-7/+0
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* pactl: Remove deprecated 'stat' behaviourPeter Meerwald2014-11-044-20/+4
| | | | | | | | | | | | the stat command should only output statistics, not info behaviour was deprecated anno 2011 in 8ace9185 "pactl: Make stat backwards compatible" -- fix this now v2: (thanks Tanu Kaskinen): * adjust shell completion Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* rtpoll: typoPeter Meerwald2014-11-041-1/+1
| | | | Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
* build-sys: Minor cosmetic tidyup of configure summaryColin Guthrie2014-11-031-3/+4
|
* launch: Disable autospawn by default when systemd daemon support is enabled.Colin Guthrie2014-11-034-2/+9
| | | | | | | | | | | | | | | | When enabled, this method is prefered over pulseaudio's built in systems so we should try our best to ensure that it cannot be spawned outside of the mechanisms desired. Packagers should call 'systemctl --global enable pulseaudio.socket' to enable the socket for all users, or alternatively ship an enabling symlink in /usr/lib/systemd/user/sockets.target.wants/ folder. It may also make sense for distributions to add in a ConditionNNN= line to the socket unit if they have a downstream mechanism for enabling or disabling pulseaudio. If individual users wish to opt out of this vendor (or administrator) decision, they can call 'systemctl --user mask pulseaudio.socket'
* launch: Add systemd units for launching pulseaudio user instancesColin Guthrie2014-11-034-1/+42
|
* launch: Avoid specifically starting PA and rely on autospawn/socket activationColin Guthrie2014-11-031-2/+0
| | | | | | | | | | | | | | This --start is patched out in several downstreams to allow users to easily disable PA by simply disabling autospawn. If autospawn is enabled, then the first pactl command will start it and if not it will fail and the script will exit. When switching to systemd socket activation, we very much do not want to start PA manually here. We could replace it with a systemctl --user start pulseaudio but really it just makes sense to rely on the socket activation as this should apply equally to non-systemd setups which use PA's own autospawn.
* socket-server: Add support for systemd socket activation.Colin Guthrie2014-11-035-29/+116
| | | | | | | | This adds support to module-native-protocol-unix to take over already listening sockets passed in via socket activation (e.g. from systemd) Most of the code is isolated to socket-server but some cleanup code also had to be tweaked to ensure we do not overzealously close open fds.
* build-sys: Add support for newer systemd without compatibility libsColin Guthrie2014-11-032-10/+25
| | | | | | | | | | | | | | In newer versions of systemd some libraries were combined for the sake of general simplicity. This change checks against the newer name first and avoids separate pkgconfig checks if it's found. We probably want to keep support for the older library names for some time. systemd does allow for the shipping of compatibility pkgconfig files to not break downstream code like ourselves which is why this likely hasn't been "fixed" until now. With this change we no longer rely on systemd having been built with those compatibility pkgconfig files.
* build-sys: Clarify some systemd sub-component variable/define names.Colin Guthrie2014-11-036-30/+30
| | | | | | | | | We currently use the term SYSTEMD when referring to libsystemd-login and JOURNAL when referring to libsystemd-journal. I will be shortly adding support for libsystemd-daemon and in preparation I figured it would be a good idea to clarify the names used currently before adding another!
* man: Fix XDG_RUNTIME_DIR variable reference.Colin Guthrie2014-11-031-1/+1
|
* socket-server: Improve readabilityTanu Kaskinen2014-11-031-16/+14
|
* alsa-mixer: Disable line-out if headphone jack is pluggedSjoerd Simons2014-11-031-0/+4
| | | | | Line-out gets muted when headphones are plugged in on HDA cards, encode this in the line-out path so pulse can match that state.