diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-09-26 18:23:13 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-09-26 18:23:13 -0400 |
| commit | 751f532b9766fb5d3c334758abea95b7bb085c5a (patch) | |
| tree | 5601ac13fba833df9c89eaa46a2026b5177748c0 /src/include/pg_config.h.win32 | |
| parent | 8b91d258844afa58e856ac354f9ba9745ff9ffb2 (diff) | |
| download | postgresql-751f532b9766fb5d3c334758abea95b7bb085c5a.tar.gz | |
Try another way to detect the result type of strerror_r().
The method we've traditionally used, of redeclaring strerror_r() to
see if the compiler complains of inconsistent declarations, turns out
not to work reliably because some compilers only report a warning,
not an error. Amazingly, this has gone undetected for years, even
though it certainly breaks our detection of whether strerror_r
succeeded.
Let's instead test whether the compiler will take the result of
strerror_r() as a switch() argument. It's possible this won't
work universally either, but it's the best idea I could come up with
on the spur of the moment.
We should probably back-patch this once the dust settles, but
first let's see what the buildfarm thinks of it.
Discussion: https://postgr.es/m/10877.1537993279@sss.pgh.pa.us
Diffstat (limited to 'src/include/pg_config.h.win32')
| -rw-r--r-- | src/include/pg_config.h.win32 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/pg_config.h.win32 b/src/include/pg_config.h.win32 index 45d47e996a..93bb77349e 100644 --- a/src/include/pg_config.h.win32 +++ b/src/include/pg_config.h.win32 @@ -665,7 +665,7 @@ /* Define to 1 if you have the ANSI C header files. */ #define STDC_HEADERS 1 -/* Define to 1 if strerror_r() returns a int. */ +/* Define to 1 if strerror_r() returns int. */ /* #undef STRERROR_R_INT */ /* Define to 1 if your <sys/time.h> declares `struct tm'. */ |