summaryrefslogtreecommitdiff
path: root/src/backend/access/index/genam.c
diff options
context:
space:
mode:
authorRobert Haas <rhaas@postgresql.org>2017-03-03 09:07:41 +0530
committerRobert Haas <rhaas@postgresql.org>2017-03-03 09:09:52 +0530
commit5a73e17317e91912b2755f7960d5bf31d374cf31 (patch)
tree9df368817ebdf24e6eca7a2a47dbccdbc67808b0 /src/backend/access/index/genam.c
parentbe6ed6451c693d9121d357996cbc21b06058b9c1 (diff)
downloadpostgresql-5a73e17317e91912b2755f7960d5bf31d374cf31.tar.gz
Improve error reporting for tuple-routing failures.
Currently, the whole row is shown without column names. Instead, adopt a style similar to _bt_check_unique() in ExecFindPartition() and show the failing key: (key1, ...) = (val1, ...). Amit Langote, per a complaint from Simon Riggs. Reviewed by me; I also adjusted the grammar in one of the comments. Discussion: http://postgr.es/m/9f9dc7ae-14f0-4a25-5485-964d9bfc19bd@lab.ntt.co.jp
Diffstat (limited to 'src/backend/access/index/genam.c')
-rw-r--r--src/backend/access/index/genam.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c
index 3599476930..a91fda7bcd 100644
--- a/src/backend/access/index/genam.c
+++ b/src/backend/access/index/genam.c
@@ -168,6 +168,10 @@ IndexScanEnd(IndexScanDesc scan)
* The passed-in values/nulls arrays are the "raw" input to the index AM,
* e.g. results of FormIndexDatum --- this is not necessarily what is stored
* in the index, but it's what the user perceives to be stored.
+ *
+ * Note: if you change anything here, check whether
+ * ExecBuildSlotPartitionKeyDescription() in execMain.c needs a similar
+ * change.
*/
char *
BuildIndexValueDescription(Relation indexRelation,