diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-02-13 21:24:14 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-02-13 22:54:52 -0500 |
| commit | 029fac2264101919b65fb6319bb994f941969471 (patch) | |
| tree | edb89110508318a04730a7caa42d312e050ef7ce /contrib/pgrowlocks | |
| parent | 629b3af27d5c2bc9d6e16b22b943ad651d4ecb56 (diff) | |
| download | postgresql-029fac2264101919b65fb6319bb994f941969471.tar.gz | |
Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.
It was never terribly consistent to use OR REPLACE (because of the lack of
comparable functionality for data types, operators, etc), and
experimentation shows that it's now positively pernicious in the extension
world. We really want a failure to occur if there are any conflicts, else
it's unclear what the extension-ownership state of the conflicted object
ought to be. Most of the time, CREATE EXTENSION will fail anyway because
of conflicts on other object types, but an extension defining only
functions can succeed, with bad results.
Diffstat (limited to 'contrib/pgrowlocks')
| -rw-r--r-- | contrib/pgrowlocks/pgrowlocks--1.0.sql | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pgrowlocks/pgrowlocks--1.0.sql b/contrib/pgrowlocks/pgrowlocks--1.0.sql index 8b5fc9a1c8..0b60fdcd07 100644 --- a/contrib/pgrowlocks/pgrowlocks--1.0.sql +++ b/contrib/pgrowlocks/pgrowlocks--1.0.sql @@ -1,6 +1,6 @@ /* contrib/pgrowlocks/pgrowlocks--1.0.sql */ -CREATE OR REPLACE FUNCTION pgrowlocks(IN relname text, +CREATE FUNCTION pgrowlocks(IN relname text, OUT locked_row TID, -- row TID OUT lock_type TEXT, -- lock type OUT locker XID, -- locking XID |