diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-10-12 15:45:03 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-10-12 15:45:03 -0400 |
| commit | 458857cc9d7d00711b272a0dabbcb591b506d6b8 (patch) | |
| tree | 2b4acca78ee2fba19273d10aa01eccc4bc111d4b /contrib/pg_buffercache | |
| parent | e0d273500a84ab94c69cbfa10ea0537604fbdda3 (diff) | |
| download | postgresql-458857cc9d7d00711b272a0dabbcb591b506d6b8.tar.gz | |
Throw a useful error message if an extension script file is fed to psql.
We have seen one too many reports of people trying to use 9.1 extension
files in the old-fashioned way of sourcing them in psql. Not only does
that usually not work (due to failure to substitute for MODULE_PATHNAME
and/or @extschema@), but if it did work they'd get a collection of loose
objects not an extension. To prevent this, insert an \echo ... \quit
line that prints a suitable error message into each extension script file,
and teach commands/extension.c to ignore lines starting with \echo.
That should not only prevent any adverse consequences of loading a script
file the wrong way, but make it crystal clear to users that they need to
do it differently now.
Tom Lane, following an idea of Andrew Dunstan's. Back-patch into 9.1
... there is not going to be much value in this if we wait till 9.2.
Diffstat (limited to 'contrib/pg_buffercache')
| -rw-r--r-- | contrib/pg_buffercache/pg_buffercache--1.0.sql | 3 | ||||
| -rw-r--r-- | contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/contrib/pg_buffercache/pg_buffercache--1.0.sql b/contrib/pg_buffercache/pg_buffercache--1.0.sql index 9407d21410..4ca4c44256 100644 --- a/contrib/pg_buffercache/pg_buffercache--1.0.sql +++ b/contrib/pg_buffercache/pg_buffercache--1.0.sql @@ -1,5 +1,8 @@ /* contrib/pg_buffercache/pg_buffercache--1.0.sql */ +-- complain if script is sourced in psql, rather than via CREATE EXTENSION +\echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit + -- Register the function. CREATE FUNCTION pg_buffercache_pages() RETURNS SETOF RECORD diff --git a/contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql b/contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql index f00a954d86..bfe6e52f8f 100644 --- a/contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql +++ b/contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql @@ -1,4 +1,7 @@ /* contrib/pg_buffercache/pg_buffercache--unpackaged--1.0.sql */ +-- complain if script is sourced in psql, rather than via CREATE EXTENSION +\echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit + ALTER EXTENSION pg_buffercache ADD function pg_buffercache_pages(); ALTER EXTENSION pg_buffercache ADD view pg_buffercache; |