diff options
author | Andres Freund <andres@anarazel.de> | 2022-03-23 13:05:59 -0700 |
---|---|---|
committer | Andres Freund <andres@anarazel.de> | 2022-03-23 13:17:59 -0700 |
commit | 61a007feed526f2acde4822e27a599cb0a734dfe (patch) | |
tree | ef31d4299a214ab9c65cec76e394ee16ac2ab42d | |
parent | c5b60a68cc08400dd2de5e2ca2908a204e6bef54 (diff) | |
download | postgresql-61a007feed526f2acde4822e27a599cb0a734dfe.tar.gz |
Don't try to translate NULL in GetConfigOptionByNum().
Noticed via -fsanitize=undefined. Introduced when a few columns in
GetConfigOptionByNum() / pg_settings started to be translated in 72be8c29a /
PG 12.
Backpatch to all affected branches, for the same reasons as 46ab07ffda9.
Discussion: https://postgr.es/m/20220323173537.ll7klrglnp4gn2um@alap3.anarazel.de
Backpatch: 12-
-rw-r--r-- | src/backend/utils/misc/guc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 1dd8c5674f..086b666cc1 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -9051,7 +9051,7 @@ GetConfigOptionByNum(int varnum, const char **values, bool *noshow) values[4] = _(conf->short_desc); /* extra_desc */ - values[5] = _(conf->long_desc); + values[5] = conf->long_desc != NULL ? _(conf->long_desc) : NULL; /* context */ values[6] = GucContext_Names[conf->context]; |