diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2021-02-07 12:54:08 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2021-02-07 12:54:08 -0500 |
| commit | a64aacf152fc1ea808b2443b41f18e4b2c1cfc61 (patch) | |
| tree | 8fb654257ba05395e382dd2dd2308cb534eda973 | |
| parent | 4384eccb15495960194a4a9dc1e2861f612f3ee5 (diff) | |
| download | postgresql-a64aacf152fc1ea808b2443b41f18e4b2c1cfc61.tar.gz | |
Revert "Propagate CTE property flags when copying a CTE list into a rule."
This reverts commit ed290896335414c6c069b9ccae1f3dcdd2fac6ba and
equivalent back-branch commits. The issue is subtler than I thought,
and it's far from new, so just before a release deadline is no time
to be fooling with it. We'll consider what to do at a bit more
leisure.
Discussion: https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com
| -rw-r--r-- | src/backend/rewrite/rewriteHandler.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c index b5dbfa2a7a..d365d0c141 100644 --- a/src/backend/rewrite/rewriteHandler.c +++ b/src/backend/rewrite/rewriteHandler.c @@ -504,9 +504,6 @@ rewriteRuleAction(Query *parsetree, * * This could possibly be fixed by using some sort of internally * generated ID, instead of names, to link CTE RTEs to their CTEs. - * However, decompiling the results would be quite confusing; note the - * merge of hasRecursive flags below, which could change the apparent - * semantics of such redundantly-named CTEs. */ foreach(lc, parsetree->cteList) { @@ -528,9 +525,6 @@ rewriteRuleAction(Query *parsetree, /* OK, it's safe to combine the CTE lists */ sub_action->cteList = list_concat(sub_action->cteList, copyObject(parsetree->cteList)); - /* ... and don't forget about the associated flags */ - sub_action->hasRecursive |= parsetree->hasRecursive; - sub_action->hasModifyingCTE |= parsetree->hasModifyingCTE; } /* |