diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-12-11 16:33:20 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-12-11 16:33:49 -0500 |
| commit | 239b01e313b5c3bc90d383b0a345e0549fe9ba96 (patch) | |
| tree | 59b9ce22f753c21ac9eff05f83f9a90c13f0a3d7 | |
| parent | d78c3ca0ea1012d9c944bae981b13151e4f86dcb (diff) | |
| download | postgresql-239b01e313b5c3bc90d383b0a345e0549fe9ba96.tar.gz | |
Fix corner-case coredump in _SPI_error_callback().
I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,
and only fills it in some time later. If an error were to happen in
between, _SPI_error_callback would try to dereference the null pointer.
This is unlikely --- there's not much between those points except
push-snapshot calls --- but it's clearly not impossible. Tweak the
callback to do nothing if the pointer isn't set yet.
It's been like this for awhile, so back-patch to all supported branches.
| -rw-r--r-- | src/backend/executor/spi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c index f8a9b52968..2beb6932ff 100644 --- a/src/backend/executor/spi.c +++ b/src/backend/executor/spi.c @@ -2419,6 +2419,9 @@ _SPI_error_callback(void *arg) const char *query = (const char *) arg; int syntaxerrposition; + if (query == NULL) /* in case arg wasn't set yet */ + return; + /* * If there is a syntax error position, convert to internal syntax error; * otherwise treat the query as an item of context stack |