summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Hagander <magnus@hagander.net>2012-02-21 17:12:25 +0100
committerMagnus Hagander <magnus@hagander.net>2012-02-21 17:13:59 +0100
commit3d2aa2c086116fd41dc7f8cff1e3ec9e5d4e2b2c (patch)
tree05920eb410e176054165387f50623a3253f1ba68
parentf22bd1570e5bc820d7493d7c60d42634c6403171 (diff)
downloadpostgresql-3d2aa2c086116fd41dc7f8cff1e3ec9e5d4e2b2c.tar.gz
Avoid double close of file handle in syslogger on win32
This causes an exception when running under a debugger or in particular when running on a debug version of Windows. Patch from MauMau
-rw-r--r--src/backend/postmaster/syslogger.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index 85e4f808db..d87d32bcf5 100644
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -588,8 +588,11 @@ SysLogger_Start(void)
errmsg("could not redirect stderr: %m")));
close(fd);
_setmode(_fileno(stderr), _O_BINARY);
- /* Now we are done with the write end of the pipe. */
- CloseHandle(syslogPipe[1]);
+ /*
+ * Now we are done with the write end of the pipe.
+ * CloseHandle() must not be called because the preceding
+ * close() closes the underlying handle.
+ */
syslogPipe[1] = 0;
#endif
redirection_done = true;