diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2009-11-29 21:02:16 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2009-11-29 21:02:16 +0000 |
| commit | 67ec9adaf13fe79c13a53c6513ec3eb7adfaaddd (patch) | |
| tree | f57d8837985a0e486df28440dcc7751334e7a9d9 | |
| parent | 22032820f958de081553da4b4475a78a8e7b2989 (diff) | |
| download | postgresql-67ec9adaf13fe79c13a53c6513ec3eb7adfaaddd.tar.gz | |
Fix session-lifespan memory leak when a plperl function is redefined:
we have to tell Perl it can release its compiled copy of the function
text. Noted by Alexey Klyukin.
Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.
| -rw-r--r-- | src/pl/plperl/plperl.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index 852b2b155b..f999495c87 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -1,7 +1,7 @@ /********************************************************************** * plperl.c - perl as a procedural language for PostgreSQL * - * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.154 2009/11/29 03:02:27 tgl Exp $ + * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.155 2009/11/29 21:02:16 tgl Exp $ * **********************************************************************/ @@ -1651,11 +1651,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger) if (!uptodate) { + hash_search(plperl_proc_hash, internal_proname, + HASH_REMOVE, NULL); + if (prodesc->reference) + SvREFCNT_dec(prodesc->reference); free(prodesc->proname); free(prodesc); prodesc = NULL; - hash_search(plperl_proc_hash, internal_proname, - HASH_REMOVE, NULL); } } |