diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2009-11-29 21:02:22 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2009-11-29 21:02:22 +0000 |
| commit | 1962ec68296271350346acc6bc1ce5e88bba8a64 (patch) | |
| tree | bc47061e37b353ef61ec2edb99c06d738f31e7c6 | |
| parent | 2164a24686bf7d6b10a9f9a9952954c76bc4bfa1 (diff) | |
| download | postgresql-1962ec68296271350346acc6bc1ce5e88bba8a64.tar.gz | |
Fix session-lifespan memory leak when a plperl function is redefined:
we have to tell Perl it can release its compiled copy of the function
text. Noted by Alexey Klyukin.
Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.
| -rw-r--r-- | src/pl/plperl/plperl.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index d2ea5b5883..b807fcc3c0 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -1,7 +1,7 @@ /********************************************************************** * plperl.c - perl as a procedural language for PostgreSQL * - * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.150.2.2 2009/10/31 18:12:05 tgl Exp $ + * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.150.2.3 2009/11/29 21:02:22 tgl Exp $ * **********************************************************************/ @@ -1528,11 +1528,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger) if (!uptodate) { + hash_search(plperl_proc_hash, internal_proname, + HASH_REMOVE, NULL); + if (prodesc->reference) + SvREFCNT_dec(prodesc->reference); free(prodesc->proname); free(prodesc); prodesc = NULL; - hash_search(plperl_proc_hash, internal_proname, - HASH_REMOVE, NULL); } } |